Chromium Code Reviews| Index: base/win/iat_patch_function.cc |
| diff --git a/base/win/iat_patch_function.cc b/base/win/iat_patch_function.cc |
| index a4a89028b870f34aa089951009ce06c6ac6f426c..8e32712353a295aae6c5580c574af5c13821822c 100644 |
| --- a/base/win/iat_patch_function.cc |
| +++ b/base/win/iat_patch_function.cc |
| @@ -56,11 +56,20 @@ DWORD ModifyCode(void* old_code, void* new_code, int length) { |
| } |
| // Change the page protection so that we can write. |
| + MEMORY_BASIC_INFORMATION memory_info; |
| DWORD error = NO_ERROR; |
| DWORD old_page_protection = 0; |
| + |
| + ::VirtualQuery(old_code, &memory_info, sizeof(memory_info)); |
|
rvargas (doing something else)
2014/01/21 18:48:50
Validate the return value.
Cait (Slow)
2014/01/21 19:53:41
Done.
|
| + |
| + DWORD is_executable = (PAGE_EXECUTE | PAGE_EXECUTE_READ | |
| + PAGE_EXECUTE_READWRITE | PAGE_EXECUTE_WRITECOPY) & |
|
rvargas (doing something else)
2014/01/21 18:48:50
nit: either indent under PAGE_EXECUTE or drop the
Cait (Slow)
2014/01/21 19:53:41
Done.
|
| + memory_info.Protect; |
| + |
| if (VirtualProtect(old_code, |
| length, |
| - PAGE_READWRITE, |
| + is_executable ? PAGE_EXECUTE_READWRITE : |
| + PAGE_READWRITE, |
| &old_page_protection)) { |
| // Write the data. |