cc: Remove cheapness estimator usage from tile manager.

cc: Remove cheapness estimator usage from tile manager.

BUG=235995
TBR=nduca@chromium.org, vmpstr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196975

[vmpstr, 2013-04-26 21:31:55]

Should we also remove cheapness from AnalysisCanvas and from Picture::Analysis
(and from telemetry) or are you consciously keeping it there?

https://codereview.chromium.org/13859012/diff/2001/cc/resources/raster_worker...
File cc/resources/raster_worker_pool.h (right):

https://codereview.chromium.org/13859012/diff/2001/cc/resources/raster_worker...
cc/resources/raster_worker_pool.h:18: typedef
base::Callback<void(PicturePileImpl* picture_pile)> RasterCallback;
That kind of looks weird to me. Is that in line with coding style?

[nduca, 2013-04-26 21:35:55]

rubberstamp lgtm when you need it.

[reveman, 2013-04-26 22:28:25]

Removed is_cheap_to_raster from PicturePileImpl::Analysis. I'd like to leave
AnalysisCanvas and telemetry changes for an immediate follow up but could
include those change here if preferred?

https://codereview.chromium.org/13859012/diff/2001/cc/resources/raster_worker...
File cc/resources/raster_worker_pool.h (right):

https://codereview.chromium.org/13859012/diff/2001/cc/resources/raster_worker...
cc/resources/raster_worker_pool.h:18: typedef
base::Callback<void(PicturePileImpl* picture_pile)> RasterCallback;
On 2013/04/26 21:31:55, vmpstr wrote:
> That kind of looks weird to me. Is that in line with coding style?

this is very inconsistent throughout chromium code. no name seems a bit more
common but I added it as presubmit complains without it. I'll remove it from
this patch as cc/ seem to use no name and I prefer to be consistent. we can
change all of cc/ later if this is wrong.

[vmpstr, 2013-04-26 22:51:35]

lgtm with nits from me

https://codereview.chromium.org/13859012/diff/2001/cc/resources/raster_worker...
File cc/resources/raster_worker_pool.h (right):

https://codereview.chromium.org/13859012/diff/2001/cc/resources/raster_worker...
cc/resources/raster_worker_pool.h:18: typedef
base::Callback<void(PicturePileImpl* picture_pile)> RasterCallback;
On 2013/04/26 22:28:25, David Reveman wrote:
> On 2013/04/26 21:31:55, vmpstr wrote:
> > That kind of looks weird to me. Is that in line with coding style?
> 
> this is very inconsistent throughout chromium code. no name seems a bit more
> common but I added it as presubmit complains without it. I'll remove it from
> this patch as cc/ seem to use no name and I prefer to be consistent. we can
> change all of cc/ later if this is wrong.

Oh I think presubmit might be confusing (PicturePileImpl*) with a C-style cast.
I'm OK with this fix.

https://codereview.chromium.org/13859012/diff/5003/cc/base/switches.cc
File cc/base/switches.cc (right):

https://codereview.chromium.org/13859012/diff/5003/cc/base/switches.cc#newcode38
cc/base/switches.cc:38: // Enable solid tile color, transparent tile metrics.
nit: Enable solid tile color and transparent tile metrics.

https://codereview.chromium.org/13859012/diff/5003/cc/base/worker_pool.cc
File cc/base/worker_pool.cc (right):

https://codereview.chromium.org/13859012/diff/5003/cc/base/worker_pool.cc#new...
cc/base/worker_pool.cc:152: static_cast<unsigned>(workers_.size() +
1)).c_str()));
nit: is the static_cast required here now?

[reveman, 2013-04-26 23:09:42]

https://codereview.chromium.org/13859012/diff/5003/cc/base/switches.cc
File cc/base/switches.cc (right):

https://codereview.chromium.org/13859012/diff/5003/cc/base/switches.cc#newcode38
cc/base/switches.cc:38: // Enable solid tile color, transparent tile metrics.
On 2013/04/26 22:51:35, vmpstr wrote:
> nit: Enable solid tile color and transparent tile metrics.

Done.

https://codereview.chromium.org/13859012/diff/5003/cc/base/worker_pool.cc
File cc/base/worker_pool.cc (right):

https://codereview.chromium.org/13859012/diff/5003/cc/base/worker_pool.cc#new...
cc/base/worker_pool.cc:152: static_cast<unsigned>(workers_.size() +
1)).c_str()));
On 2013/04/26 22:51:35, vmpstr wrote:
> nit: is the static_cast required here now?

Done.

[commit-bot: I haz the power, 2013-04-26 23:10:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/13859012/7016

[commit-bot: I haz the power, 2013-04-26 23:24:45]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-26 23:39:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/13859012/9005

[commit-bot: I haz the power, 2013-04-26 23:43:11]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[reveman, 2013-04-28 02:18:25]

Committed patchset #8 manually as r196975 (presubmit successful).