Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/DownloadController.java

Issue 13859009: Adding a call to support download initiated context menu (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressing comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/DownloadController.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/DownloadController.java b/content/public/android/java/src/org/chromium/content/browser/DownloadController.java
index 77936fc898d1f1a4ead0f6e36aee6751c4ee7cb8..c3ed48df65fed8160eb9e112aac53edefcd56fac 100644
--- a/content/public/android/java/src/org/chromium/content/browser/DownloadController.java
+++ b/content/public/android/java/src/org/chromium/content/browser/DownloadController.java
@@ -52,29 +52,30 @@ class DownloadController {
}
/**
- * Notifies the download delegate that a new POST download has started.
+ * Notifies the download delegate that a new download has started. This can
+ * be either a POST download or a GET download with authentication.
*/
@CalledByNative
- public void onHttpPostDownloadStarted(ContentViewCore view) {
+ public void onDownloadStarted(ContentViewCore view) {
ContentViewDownloadDelegate downloadDelagate = downloadDelegateFromView(view);
if (downloadDelagate != null) {
- downloadDelagate.onHttpPostDownloadStarted();
+ downloadDelagate.onDownloadStarted();
}
}
/**
- * Notifies the download delegate that a POST download completed and passes along info about the
- * download.
+ * Notifies the download delegate that a download completed and passes along info about the
+ * download. This can be either a POST download or a GET download with authentication.
*/
@CalledByNative
- public void onHttpPostDownloadCompleted(ContentViewCore view, String url,
+ public void onDownloadCompleted(ContentViewCore view, String url,
String contentDisposition, String mimetype, String path,
long contentLength, boolean successful) {
ContentViewDownloadDelegate downloadDelagate = downloadDelegateFromView(view);
if (downloadDelagate != null) {
- downloadDelagate.onHttpPostDownloadCompleted(
+ downloadDelagate.onDownloadCompleted(
url, mimetype, path, contentLength, successful);
}
}

Powered by Google App Engine
This is Rietveld 408576698