Adding a call to support download initiated context menu

content/public/browser/android/download_controller_android.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_ANDROID_DOWNLOAD_CONTROLLER_ANDROID_H_
 #define CONTENT_PUBLIC_BROWSER_ANDROID_DOWNLOAD_CONTROLLER_ANDROID_H_
 
 #include "content/common/content_export.h"
+#include "content/public/common/context_menu_params.h"
 
 namespace content {
 class DownloadItem;
+class WebContents;
 
 // Interface to request GET downloads and send notifications for POST
 // downloads.
 class CONTENT_EXPORT DownloadControllerAndroid {
  public:
   // Returns the singleton instance of the DownloadControllerAndroid.
   static DownloadControllerAndroid* Get();
 
   // Starts a new download request with Android. Should be called on the
   // UI thread.
   virtual void CreateGETDownload(int render_process_id, int render_view_id,
                                  int request_id) = 0;
 
   // Should be called when a POST download is started. Notifies the embedding
   // app about the download. Should be called on the UI thread.
   virtual void OnPostDownloadStarted(DownloadItem* download_item) = 0;

[nilesh, 2013/04/12 16:44:14]

Also rename this to OnDownloadStarted. With this and your earlier change for
http_auth, this methods is called for more than just Post downloads.

[nilesh, 2013/04/12 16:50:07]

actually you can add a note in the comment and a TODO. POST is used in the
method names on the java side too (DownloadController and
ContentViewDownloadDelegate)

[qinmin, 2013/04/15 18:56:51]

Done.

[qinmin, 2013/04/15 18:56:51]

Fixed naming in all the related classes, and also the comments.
On 2013/04/12 16:50:07, nilesh wrote:

+
+  // Called when a download is initiated by context menu.
+  virtual void StartContextMenuDownload(
+      const ContextMenuParams& params, WebContents* web_contents,
+      bool is_link) = 0;

[nilesh, 2013/04/12 16:27:45]

looking at the caller, is_link can be decided based on ContextMenuParams. Dont
need this extra param.

[qinmin, 2013/04/15 18:56:51]

we still need this. We need to know whether "save image" or "save image link" is
selected.

On 2013/04/12 16:27:45, nilesh wrote:

+
  protected:
   virtual ~DownloadControllerAndroid() {};
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_ANDROID_DOWNLOAD_CONTROLLER_ANDROID_H_