Adding a call to support download initiated context menu

content/browser/android/download_controller_android_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/download_controller_android_impl.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/browser/android/content_view_core_impl.h"
 #include "content/browser/download/download_item_impl.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/browser/renderer_host/render_view_host_delegate.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
 #include "content/browser/web_contents/web_contents_impl.h"
+#include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/global_request_id.h"
 #include "content/public/browser/web_contents_view.h"
 #include "jni/DownloadController_jni.h"
 #include "net/cookies/cookie_options.h"
 #include "net/cookies/cookie_store.h"
 #include "net/http/http_request_headers.h"
 #include "net/http/http_response_headers.h"
 #include "net/url_request/url_request.h"
 #include "net/url_request/url_request_context.h"
@@ skipping 280 matching lines @@
     // DownloadController.getInstance(), which will call Init()
     // if Java DownloadController is not instantiated already.
     JNIEnv* env = base::android::AttachCurrentThread();
     Java_DownloadController_getInstance(env);
   }
 
   DCHECK(java_object_);
   return java_object_;
 }
 
+void DownloadControllerAndroidImpl::StartContextMenuDownload(
+    const ContextMenuParams& params, WebContents* web_contents, bool is_link) {
+  const GURL& url = is_link ? params.link_url : params.src_url;
+  const GURL& referrer = params.frame_url.is_empty() ?
+      params.page_url : params.frame_url;
+  DownloadManager* dlm = content::BrowserContext::GetDownloadManager(

[nilesh, 2013/04/12 16:27:45]

dont need content::
here and below

[nilesh, 2013/04/12 16:27:45]

We are supposed to use the _impl version inside content.
DownloadManagerImpl* dlm =
static_cast<DownloadManagerImpl*>(BrowserContext::GetDownloadManager(
          web_contents()->GetBrowserContext());
I am not sure how strictly this is followed though.

Also please explicitly include what you use. 
DownloadManagerImpl, DownloadUrlParameters, Referrer

[qinmin, 2013/04/15 18:56:51]

Done.

[qinmin, 2013/04/15 18:56:51]

Done.

+      web_contents->GetBrowserContext());
+  scoped_ptr<content::DownloadUrlParameters> dl_params(
+      DownloadUrlParameters::FromWebContents(web_contents, url));
+  dl_params->set_referrer(
+      Referrer(referrer, params.referrer_policy));
+  if (!is_link)

[nilesh, 2013/04/12 16:27:45]

if (is_link) .. else ..
I find this easier to read.

[qinmin, 2013/04/15 18:56:51]

Done.

+    dl_params->set_prefer_cache(true);
+  else
+    dl_params->set_referrer_encoding(params.frame_charset);

[nilesh, 2013/04/12 16:27:45]

Why is referrer encoding only set for is_link?

[qinmin, 2013/04/15 18:56:51]

This is from the upstream saving logic. I think for image/video files, referrer
doesn't make too much sense. You can embed a url from any sites on ur page, so
the referrer doesn't matter.

On 2013/04/12 16:27:45, nilesh wrote:

+  dl_params->set_prompt(false);
+  dlm->DownloadUrl(dl_params.Pass());
+}
+
 DownloadControllerAndroidImpl::DownloadInfoAndroid::DownloadInfoAndroid(
     net::URLRequest* request) {
   request->GetResponseHeaderByName("content-disposition", &content_disposition);
 
   if (request->response_headers())
     request->response_headers()->GetMimeType(&original_mime_type);
 
   request->extra_request_headers().GetHeader(
       net::HttpRequestHeaders::kUserAgent, &user_agent);
   GURL referer_url(request->referrer());
   if (referer_url.is_valid())
     referer = referer_url.spec();
   if (!request->url_chain().empty()) {
     original_url = request->url_chain().front();
     url = request->url_chain().back();
   }
 }
 
 DownloadControllerAndroidImpl::DownloadInfoAndroid::~DownloadInfoAndroid() {}
 
 }  // namespace content