build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java - Issue 1385893004: GN incremental_install: Enable lib copying for all devices

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java

Issue 1385893004: GN incremental_install: Enable lib copying for all devices (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tweak what is split up Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java

diff --git a/build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java b/build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java

index 39256a61314aa63919648258058d4e9e983428f1..6e48f3b1ea7073e03b9206e46f38f2a012634a8b 100644

--- a/build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java

+++ b/build/android/incremental_install/java/org/chromium/incrementalinstall/LockFile.java

@@ -99,6 +99,7 @@ final class LockFile {

outputStream.close();

} catch (IOException e) {

// Do nothing. We didn't get the lock.

+ Log.w(TAG, "Exception trying to acquire lock " + file, e);

pkotwicz 2015/10/05 19:43:18 Doesn't this belong in https://codereview.chromium

agrieve 2015/10/05 19:46:40 Done.

}

return null;

}

« no previous file with comments | « build/android/incremental_install/java/org/chromium/incrementalinstall/ClassLoaderPatcher.java ('k') | no next file » | no next file with comments »