content/common/gpu/client/command_buffer_proxy_impl.h - Issue 1385883002: Leave CreateStreamTexture route id out of the GL interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/command_buffer_proxy_impl.h

Issue 1385883002: Leave CreateStreamTexture route id out of the GL interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/renderer/media/android/stream_texture_factory_impl.h » ('j') | content/renderer/media/android/stream_texture_factory_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/command_buffer_proxy_impl.h

diff --git a/content/common/gpu/client/command_buffer_proxy_impl.h b/content/common/gpu/client/command_buffer_proxy_impl.h

index 31326466bc08f945a776e3a513706199c7841e04..d8e381757385206e79086251733c8c94489a5881 100644

--- a/content/common/gpu/client/command_buffer_proxy_impl.h

+++ b/content/common/gpu/client/command_buffer_proxy_impl.h

@@ -118,7 +118,7 @@ class CommandBufferProxyImpl

const base::Closure& callback) override;

void SignalQuery(uint32 query, const base::Closure& callback) override;

void SetSurfaceVisible(bool visible) override;

- uint32 CreateStreamTexture(uint32 texture_id) override;

+ uint32 CreateStreamTexture(uint32 texture_id) final;

no sievers 2015/10/26 21:35:33 It'd be nice to pull the other changes you suggest

sivag 2015/10/27 15:42:44 Done.

void SetLock(base::Lock* lock) override;

bool IsGpuChannelLost() override;

gpu::CommandBufferNamespace GetNamespaceID() const override;