Leave CreateStreamTexture route id out of the GL interface.

Remove CreateStreamTexture from GL interfaces.

Remove CreateStreamTexture from gpu_control.h.
Use CreateStreamTexture as a non virtual function in
command_buffer_proxy and in_process_command_buffer
(for STFSynchronous).Use CreateStreamTexture
instead of gl->CreateStreamTextureCHROMIUM.

BUG=516585, 339191
Committed: https://crrev.com/5d4feb054523b92862e6e4aca237ca44401fc404
Cr-Commit-Position: refs/heads/master@{#359778}

[sivag, 2015-10-05 11:49:32]

siva.gunturi@samsung.com changed reviewers:
+ sievers@chromium.org

[sivag, 2015-10-05 11:51:55]

ptal..
I added a new signature CreateStreamTexureImage which is non-virtual to achieve
this.

[sivag, 2015-10-13 17:47:01]

hi sievers,
Sorry, i was busy was some other schedule for some time and started looking into
this can you ptal..
Thanks.

[sivag, 2015-10-13 17:49:38]

hi sievers,
Sorry, i was busy with some other schedule for some time and now i started
looking into this can you ptal..
Thanks.

[sivag, 2015-10-20 12:14:08]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-20 12:14:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/60001

[commit-bot: I haz the power, 2015-10-20 12:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 12:23:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sivag, 2015-10-20 12:59:32]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-20 13:00:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/80001

[sivag, 2015-10-20 13:20:33]

siva.gunturi@samsung.com changed reviewers:
+ piman@chromium.org

[sivag, 2015-10-20 13:21:08]

siva.gunturi@samsung.com changed reviewers:
+ qinmin@chromium.org

[commit-bot: I haz the power, 2015-10-20 13:59:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-20 13:59:18]

Dry run: This issue passed the CQ dry run.

[no sievers, 2015-10-26 21:35:33]

https://codereview.chromium.org/1385883002/diff/80001/content/common/gpu/clie...
File content/common/gpu/client/command_buffer_proxy_impl.h (right):

https://codereview.chromium.org/1385883002/diff/80001/content/common/gpu/clie...
content/common/gpu/client/command_buffer_proxy_impl.h:121: uint32
CreateStreamTexture(uint32 texture_id) final;
It'd be nice to pull the other changes you suggest in crbug.com/516585 into this
patch so we can actually make this non-virtual and remove it from the GL
interface.

https://codereview.chromium.org/1385883002/diff/80001/content/renderer/media/...
File content/renderer/media/android/stream_texture_factory_impl.cc (right):

https://codereview.chromium.org/1385883002/diff/80001/content/renderer/media/...
content/renderer/media/android/stream_texture_factory_impl.cc:151: gl->Flush();
ShallowFlushCHROMIUM() is good enough (and same as before)

https://codereview.chromium.org/1385883002/diff/80001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1385883002/diff/80001/content/renderer/render...
content/renderer/render_frame_impl.cc:5094: ContextProviderCommandBuffer* ptr =
reinterpret_cast<
We should avoid this cast. One way would be by having a shared
StreamTextureFactoryImpl per RenderThreadImpl, then RTImpl can create it when it
creates ContextProviderCommandBuffer. But that needs pulling |frame_id| out of
STFImpl's constructor (and maybe passing it to WMPAndroid instead so that can
pass it to EstablishPeer?).

Ugh, sorry, looks like this is all not so straightforward to untangle and make
nicer.

[sivag, 2015-10-27 13:32:22]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-27 13:32:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/120001

[sivag, 2015-10-27 13:40:11]

Description was changed from

==========
Leave the route id out of the GL interface.

To achieve this
1.)Make CommandBufferProxyImpl::CreateStreamTexture() non-virtual.
2.)Make the StreamTextureFactoryImpl() constructor take a
ContextProviderCommandBuffer instead of base class Interface
cc::ContextProvider.

BUG=516585
==========

to

==========
Leave the route id out of the GL interface.

Remove CreateStreamTexture from gpu_control.h. 
Add CreateStreamTexture as a member function in 
command_buffer_proxy and in_process_command_buffer
(for STFSynchronous).Use CreateStreamTexture
instead of gl->CreateStreamTextureCHROMIUM.

BUG=516585
==========

[sivag, 2015-10-27 13:41:14]

Description was changed from

==========
Leave the route id out of the GL interface.

Remove CreateStreamTexture from gpu_control.h. 
Add CreateStreamTexture as a member function in 
command_buffer_proxy and in_process_command_buffer
(for STFSynchronous).Use CreateStreamTexture
instead of gl->CreateStreamTextureCHROMIUM.

BUG=516585
==========

to

==========
Leave the CreateStreamTexture route id out of the GL interface.

Remove CreateStreamTexture from gpu_control.h. 
Add CreateStreamTexture as a member function in 
command_buffer_proxy and in_process_command_buffer
(for STFSynchronous).Use CreateStreamTexture
instead of gl->CreateStreamTextureCHROMIUM.

BUG=516585
==========

[sivag, 2015-10-27 13:41:41]

Description was changed from

==========
Leave the CreateStreamTexture route id out of the GL interface.

Remove CreateStreamTexture from gpu_control.h. 
Add CreateStreamTexture as a member function in 
command_buffer_proxy and in_process_command_buffer
(for STFSynchronous).Use CreateStreamTexture
instead of gl->CreateStreamTextureCHROMIUM.

BUG=516585
==========

to

==========
Leave CreateStreamTexture route id out of the GL interface.

Remove CreateStreamTexture from gpu_control.h. 
Add CreateStreamTexture as a member function in 
command_buffer_proxy and in_process_command_buffer
(for STFSynchronous).Use CreateStreamTexture
instead of gl->CreateStreamTextureCHROMIUM.

BUG=516585
==========

[commit-bot: I haz the power, 2015-10-27 13:46:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-27 13:46:08]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[sivag, 2015-10-27 14:05:13]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-27 14:05:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/140001

[commit-bot: I haz the power, 2015-10-27 14:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-27 14:19:09]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sivag, 2015-10-27 14:25:06]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-27 14:25:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/160001

[sivag, 2015-10-27 14:31:54]

Description was changed from

==========
Leave CreateStreamTexture route id out of the GL interface.

Remove CreateStreamTexture from gpu_control.h. 
Add CreateStreamTexture as a member function in 
command_buffer_proxy and in_process_command_buffer
(for STFSynchronous).Use CreateStreamTexture
instead of gl->CreateStreamTextureCHROMIUM.

BUG=516585
==========

to

==========
Leave CreateStreamTexture route id out of the GL interface.

Remove CreateStreamTexture from gpu_control.h. 
Use CreateStreamTexture as a non virtual function in 
command_buffer_proxy and in_process_command_buffer
(for STFSynchronous).Use CreateStreamTexture
instead of gl->CreateStreamTextureCHROMIUM.

BUG=516585
==========

[commit-bot: I haz the power, 2015-10-27 15:22:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-27 15:22:06]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[sivag, 2015-10-27 15:42:44]

ptal..

https://codereview.chromium.org/1385883002/diff/80001/content/common/gpu/clie...
File content/common/gpu/client/command_buffer_proxy_impl.h (right):

https://codereview.chromium.org/1385883002/diff/80001/content/common/gpu/clie...
content/common/gpu/client/command_buffer_proxy_impl.h:121: uint32
CreateStreamTexture(uint32 texture_id) final;
On 2015/10/26 21:35:33, sievers wrote:
> It'd be nice to pull the other changes you suggest in crbug.com/516585 into
this
> patch so we can actually make this non-virtual and remove it from the GL
> interface.

Done.

https://codereview.chromium.org/1385883002/diff/80001/content/renderer/media/...
File content/renderer/media/android/stream_texture_factory_impl.cc (right):

https://codereview.chromium.org/1385883002/diff/80001/content/renderer/media/...
content/renderer/media/android/stream_texture_factory_impl.cc:151: gl->Flush();
On 2015/10/26 21:35:33, sievers wrote:
> ShallowFlushCHROMIUM() is good enough (and same as before)

Done.

https://codereview.chromium.org/1385883002/diff/80001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1385883002/diff/80001/content/renderer/render...
content/renderer/render_frame_impl.cc:5094: ContextProviderCommandBuffer* ptr =
reinterpret_cast<
On 2015/10/26 21:35:33, sievers wrote:
> We should avoid this cast. One way would be by having a shared
> StreamTextureFactoryImpl per RenderThreadImpl, then RTImpl can create it when
it
> creates ContextProviderCommandBuffer. But that needs pulling |frame_id| out of
> STFImpl's constructor (and maybe passing it to WMPAndroid instead so that can
> pass it to EstablishPeer?).
> 
> Ugh, sorry, looks like this is all not so straightforward to 
untangle and make

> nicer.
I will check this.

[no sievers, 2015-10-27 16:58:57]

Yes, this should be a good direction to clean up the id usage. It basically
pushes things further down into the existing abstractions (StreamTextureFactory)
and out of the GL interface.

https://codereview.chromium.org/1385883002/diff/160001/content/browser/androi...
File content/browser/android/in_process/synchronous_compositor_factory_impl.cc
(right):

https://codereview.chromium.org/1385883002/diff/160001/content/browser/androi...
content/browser/android/in_process/synchronous_compositor_factory_impl.cc:102:
uint32 CreateStreamTexture(uint32 texture_id) {
nit: override

https://codereview.chromium.org/1385883002/diff/160001/content/common/gpu/cli...
File content/common/gpu/client/command_buffer_proxy_impl.h (right):

https://codereview.chromium.org/1385883002/diff/160001/content/common/gpu/cli...
content/common/gpu/client/command_buffer_proxy_impl.h:122: uint32
CreateStreamTexture(uint32 texture_id);
nit: move it down to the non-virtual methods

https://codereview.chromium.org/1385883002/diff/160001/content/renderer/rende...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1385883002/diff/160001/content/renderer/rende...
content/renderer/render_frame_impl.cc:5177: ContextProviderCommandBuffer* ptr =
reinterpret_cast<
this cast we still want to avoid

https://codereview.chromium.org/1385883002/diff/160001/gpu/command_buffer/ser...
File gpu/command_buffer/service/in_process_command_buffer.h (right):

https://codereview.chromium.org/1385883002/diff/160001/gpu/command_buffer/ser...
gpu/command_buffer/service/in_process_command_buffer.h:128: uint32
CreateStreamTexture(uint32 texture_id);
nit: move to non-virtual functions

https://codereview.chromium.org/1385883002/diff/160001/gpu/command_buffer/tes...
File gpu/command_buffer/tests/gl_manager.h (right):

https://codereview.chromium.org/1385883002/diff/160001/gpu/command_buffer/tes...
gpu/command_buffer/tests/gl_manager.h:130: uint32 CreateStreamTexture(uint32
texture_id);
you can remove this and the stub implementation in the .cc file now

https://codereview.chromium.org/1385883002/diff/160001/gpu/gles2_conform_supp...
File gpu/gles2_conform_support/egl/display.h (right):

https://codereview.chromium.org/1385883002/diff/160001/gpu/gles2_conform_supp...
gpu/gles2_conform_support/egl/display.h:98: uint32 CreateStreamTexture(uint32
texture_id);
remove this and stub impl also

https://codereview.chromium.org/1385883002/diff/160001/mojo/gles2/command_buf...
File mojo/gles2/command_buffer_client_impl.h (right):

https://codereview.chromium.org/1385883002/diff/160001/mojo/gles2/command_buf...
mojo/gles2/command_buffer_client_impl.h:75: uint32 CreateStreamTexture(uint32
texture_id);
remove this and stub impl also

https://codereview.chromium.org/1385883002/diff/160001/ppapi/proxy/ppapi_comm...
File ppapi/proxy/ppapi_command_buffer_proxy.h (right):

https://codereview.chromium.org/1385883002/diff/160001/ppapi/proxy/ppapi_comm...
ppapi/proxy/ppapi_command_buffer_proxy.h:68: uint32 CreateStreamTexture(uint32
texture_id);
remove this and stub impl

[piman, 2015-10-27 17:16:01]

https://codereview.chromium.org/1385883002/diff/160001/components/mus/gles2/c...
File components/mus/gles2/command_buffer_local.h (right):

https://codereview.chromium.org/1385883002/diff/160001/components/mus/gles2/c...
components/mus/gles2/command_buffer_local.h:71: uint32
CreateStreamTexture(uint32 texture_id);
Here and other places: if there is no functional implementation, just remove the
method altogether (it wouldn't be called anyway).

[sivag, 2015-11-04 15:52:07]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 15:52:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/200001

[commit-bot: I haz the power, 2015-11-04 16:08:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 16:08:53]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[sivag, 2015-11-05 04:46:25]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 04:47:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/220001

[sivag, 2015-11-05 05:03:26]

Description was changed from

==========
Leave CreateStreamTexture route id out of the GL interface.

Remove CreateStreamTexture from gpu_control.h. 
Use CreateStreamTexture as a non virtual function in 
command_buffer_proxy and in_process_command_buffer
(for STFSynchronous).Use CreateStreamTexture
instead of gl->CreateStreamTextureCHROMIUM.

BUG=516585
==========

to

==========
Leave CreateStreamTexture route id out of the GL interface.

Remove CreateStreamTexture from gpu_control.h. 
Use CreateStreamTexture as a non virtual function in 
command_buffer_proxy and in_process_command_buffer
(for STFSynchronous).Use CreateStreamTexture
instead of gl->CreateStreamTextureCHROMIUM.

BUG=516585, 339191
==========

[sivag, 2015-11-05 05:23:48]

siva.gunturi@samsung.com changed reviewers:
+ ben@chromium.org

[sivag, 2015-11-05 05:25:33]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-05 05:25:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/240001

[commit-bot: I haz the power, 2015-11-05 07:48:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-05 07:48:56]

Dry run: This issue passed the CQ dry run.

[sivag, 2015-11-05 09:42:50]

ptal..

https://codereview.chromium.org/1385883002/diff/160001/components/mus/gles2/c...
File components/mus/gles2/command_buffer_local.h (right):

https://codereview.chromium.org/1385883002/diff/160001/components/mus/gles2/c...
components/mus/gles2/command_buffer_local.h:71: uint32
CreateStreamTexture(uint32 texture_id);
On 2015/10/27 17:16:01, piman (slow to review) wrote:
> Here and other places: if there is no functional implementation, just remove
the
> method altogether (it wouldn't be called anyway).

Done.

https://codereview.chromium.org/1385883002/diff/160001/content/browser/androi...
File content/browser/android/in_process/synchronous_compositor_factory_impl.cc
(right):

https://codereview.chromium.org/1385883002/diff/160001/content/browser/androi...
content/browser/android/in_process/synchronous_compositor_factory_impl.cc:102:
uint32 CreateStreamTexture(uint32 texture_id) {
On 2015/10/27 16:58:56, sievers wrote:
> nit: override

Done.

https://codereview.chromium.org/1385883002/diff/160001/content/common/gpu/cli...
File content/common/gpu/client/command_buffer_proxy_impl.h (right):

https://codereview.chromium.org/1385883002/diff/160001/content/common/gpu/cli...
content/common/gpu/client/command_buffer_proxy_impl.h:122: uint32
CreateStreamTexture(uint32 texture_id);
On 2015/10/27 16:58:56, sievers wrote:
> nit: move it down to the non-virtual methods

Done.

https://codereview.chromium.org/1385883002/diff/160001/content/renderer/rende...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/1385883002/diff/160001/content/renderer/rende...
content/renderer/render_frame_impl.cc:5177: ContextProviderCommandBuffer* ptr =
reinterpret_cast<
On 2015/10/27 16:58:56, sievers wrote:
> this cast we still want to avoid

Done.

https://codereview.chromium.org/1385883002/diff/160001/gpu/command_buffer/ser...
File gpu/command_buffer/service/in_process_command_buffer.h (right):

https://codereview.chromium.org/1385883002/diff/160001/gpu/command_buffer/ser...
gpu/command_buffer/service/in_process_command_buffer.h:128: uint32
CreateStreamTexture(uint32 texture_id);
On 2015/10/27 16:58:56, sievers wrote:
> nit: move to non-virtual functions

Done.

https://codereview.chromium.org/1385883002/diff/160001/gpu/command_buffer/tes...
File gpu/command_buffer/tests/gl_manager.h (right):

https://codereview.chromium.org/1385883002/diff/160001/gpu/command_buffer/tes...
gpu/command_buffer/tests/gl_manager.h:130: uint32 CreateStreamTexture(uint32
texture_id);
On 2015/10/27 16:58:56, sievers wrote:
> you can remove this and the stub implementation in the .cc file now

Done.

https://codereview.chromium.org/1385883002/diff/160001/gpu/gles2_conform_supp...
File gpu/gles2_conform_support/egl/display.h (right):

https://codereview.chromium.org/1385883002/diff/160001/gpu/gles2_conform_supp...
gpu/gles2_conform_support/egl/display.h:98: uint32 CreateStreamTexture(uint32
texture_id);
On 2015/10/27 16:58:56, sievers wrote:
> remove this and stub impl also

Done.

https://codereview.chromium.org/1385883002/diff/160001/mojo/gles2/command_buf...
File mojo/gles2/command_buffer_client_impl.h (right):

https://codereview.chromium.org/1385883002/diff/160001/mojo/gles2/command_buf...
mojo/gles2/command_buffer_client_impl.h:75: uint32 CreateStreamTexture(uint32
texture_id);
On 2015/10/27 16:58:56, sievers wrote:
> remove this and stub impl also

Done.

https://codereview.chromium.org/1385883002/diff/160001/ppapi/proxy/ppapi_comm...
File ppapi/proxy/ppapi_command_buffer_proxy.h (right):

https://codereview.chromium.org/1385883002/diff/160001/ppapi/proxy/ppapi_comm...
ppapi/proxy/ppapi_command_buffer_proxy.h:68: uint32 CreateStreamTexture(uint32
texture_id);
On 2015/10/27 16:58:57, sievers wrote:
> remove this and stub impl

Done.

[no sievers, 2015-11-06 22:08:41]

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/media...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/media...
content/renderer/media/android/webmediaplayer_android.cc:277: frame_id_ = 0;
nit: not needed

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/rende...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1445: // Create shared
StreamTextureFactoryImpl per RenderThreadImpl when we
can you move this android block to GetStreamTextureFactory() below, so we do it
lazily there instead?

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/rende...
File content/renderer/render_thread_impl.h (right):

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/rende...
content/renderer/render_thread_impl.h:113: class StreamTextureFactory;
move this below inside a #if defined(OS_ANDROID) block

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/rende...
content/renderer/render_thread_impl.h:633: #if defined(OS_ANDROID)
nit: newline before

https://codereview.chromium.org/1385883002/diff/240001/gpu/command_buffer/cli...
File gpu/command_buffer/client/gl_in_process_context.h (right):

https://codereview.chromium.org/1385883002/diff/240001/gpu/command_buffer/cli...
gpu/command_buffer/client/gl_in_process_context.h:85: virtual uint32
CreateStreamTexture(uint32 texture_id) = 0;
nit: can this be inside ifdef android?

https://codereview.chromium.org/1385883002/diff/240001/gpu/command_buffer/ser...
File gpu/command_buffer/service/in_process_command_buffer.h (right):

https://codereview.chromium.org/1385883002/diff/240001/gpu/command_buffer/ser...
gpu/command_buffer/service/in_process_command_buffer.h:180: uint32
CreateStreamTexture(uint32 texture_id);
here too: can this be ifdef android?

[sivag, 2015-11-09 12:02:27]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-09 12:02:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/280001

[sivag, 2015-11-09 12:08:56]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-09 12:09:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/300001

[commit-bot: I haz the power, 2015-11-09 12:19:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-09 12:19:13]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[sivag, 2015-11-09 13:08:31]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-09 13:08:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/320001

[sivag, 2015-11-09 14:06:32]

@sievers, ptal..

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/media...
File content/renderer/media/android/webmediaplayer_android.cc (right):

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/media...
content/renderer/media/android/webmediaplayer_android.cc:277: frame_id_ = 0;
On 2015/11/06 22:08:41, sievers wrote:
> nit: not needed

Done.

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/rende...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1445: // Create shared
StreamTextureFactoryImpl per RenderThreadImpl when we
On 2015/11/06 22:08:41, sievers wrote:
> can you move this android block to GetStreamTextureFactory() below, so we do
it
> lazily there instead?

Done.

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/rende...
File content/renderer/render_thread_impl.h (right):

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/rende...
content/renderer/render_thread_impl.h:113: class StreamTextureFactory;
On 2015/11/06 22:08:41, sievers wrote:
> move this below inside a #if defined(OS_ANDROID) block

Done.

https://codereview.chromium.org/1385883002/diff/240001/content/renderer/rende...
content/renderer/render_thread_impl.h:633: #if defined(OS_ANDROID)
On 2015/11/06 22:08:41, sievers wrote:
> nit: newline before

Done.

https://codereview.chromium.org/1385883002/diff/240001/gpu/command_buffer/cli...
File gpu/command_buffer/client/gl_in_process_context.h (right):

https://codereview.chromium.org/1385883002/diff/240001/gpu/command_buffer/cli...
gpu/command_buffer/client/gl_in_process_context.h:85: virtual uint32
CreateStreamTexture(uint32 texture_id) = 0;
On 2015/11/06 22:08:41, sievers wrote:
> nit: can this be inside ifdef android?

Done.

https://codereview.chromium.org/1385883002/diff/240001/gpu/command_buffer/ser...
File gpu/command_buffer/service/in_process_command_buffer.h (right):

https://codereview.chromium.org/1385883002/diff/240001/gpu/command_buffer/ser...
gpu/command_buffer/service/in_process_command_buffer.h:180: uint32
CreateStreamTexture(uint32 texture_id);
On 2015/11/06 22:08:41, sievers wrote:
> here too: can this be ifdef android?

Done.

[commit-bot: I haz the power, 2015-11-09 14:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-09 14:33:05]

Dry run: This issue passed the CQ dry run.

[no sievers, 2015-11-09 21:27:34]

https://codereview.chromium.org/1385883002/diff/320001/content/renderer/rende...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/1385883002/diff/320001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1484: stream_texture_factory_ =
StreamTextureFactoryImpl::Create(
If you are creating a new factory every time, then please rename the function to
'CreateStreamTextureFactory()' and remove |stream_texture_factory_| (no need to
keep it as a member).

nit: Then you might as well also pull the SynchronousComopositorFactory version
of the code into here.

Or if you do want to cache it on the other hand, then return the cached version
as long as it's not lost (you can do a similar check to
SharedMainThreadContextProvider() above, but check
stream_texture_factory_->ContextGL()->GetGraphicsResetStatusKHR()) before
returning the cached one (otherwise attempt to create a new one).

[sivag, 2015-11-10 06:04:44]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-10 06:05:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/340001

[commit-bot: I haz the power, 2015-11-10 07:38:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-10 07:38:23]

Dry run: This issue passed the CQ dry run.

[sivag, 2015-11-10 13:18:56]

sievers, ptal..

https://codereview.chromium.org/1385883002/diff/320001/content/renderer/rende...
File content/renderer/render_thread_impl.cc (right):

https://codereview.chromium.org/1385883002/diff/320001/content/renderer/rende...
content/renderer/render_thread_impl.cc:1484: stream_texture_factory_ =
StreamTextureFactoryImpl::Create(
On 2015/11/09 21:27:34, sievers wrote:
> If you are creating a new factory every time, then please rename the function
to
> 'CreateStreamTextureFactory()' and remove |stream_texture_factory_| (no need
to
> keep it as a member).
> 
> nit: Then you might as well also pull the SynchronousComopositorFactory
version
> of the code into here.
> 
> Or if you do want to cache it on the other hand, then return the cached
version
> as long as it's not lost (you can do a similar check to
> SharedMainThreadContextProvider() above, but check
> stream_texture_factory_->ContextGL()->GetGraphicsResetStatusKHR()) before
> returning the cached one (otherwise attempt to create a new one).
> 

Done.

[no sievers, 2015-11-10 18:30:57]

Description was changed from

==========
Leave CreateStreamTexture route id out of the GL interface.

Remove CreateStreamTexture from gpu_control.h. 
Use CreateStreamTexture as a non virtual function in 
command_buffer_proxy and in_process_command_buffer
(for STFSynchronous).Use CreateStreamTexture
instead of gl->CreateStreamTextureCHROMIUM.

BUG=516585, 339191
==========

to

==========
Remove CreateStreamTexture from GL interfaces.

Remove CreateStreamTexture from gpu_control.h. 
Use CreateStreamTexture as a non virtual function in 
command_buffer_proxy and in_process_command_buffer
(for STFSynchronous).Use CreateStreamTexture
instead of gl->CreateStreamTextureCHROMIUM.

BUG=516585, 339191
==========

[no sievers, 2015-11-10 18:31:22]

lgtm

[sivag, 2015-11-10 19:42:06]

siva.gunturi@samsung.com changed reviewers:
+ bbudge@chromium.org, blundell@chromium.org

[sivag, 2015-11-10 19:47:40]

@ben, @blundell, @bbudge

ptal below files 

ben@chromium.org  -> mojo/,  third_party/mojo
blundell@chromium.org  -> components/
bbudge@chromium.org -> ppapi/

[bbudge, 2015-11-10 22:39:04]

ppapi LGTM

[sivag, 2015-11-11 18:11:15]

siva.gunturi@samsung.com changed reviewers:
+ jochen@chromium.org

[sivag, 2015-11-11 18:15:28]

@Ben Goodger ptal, -> mojo/,  third_party/mojo/ files
 
@jochen ptal-> components/ files.

[jochen (gone - plz use gerrit), 2015-11-11 20:42:11]

components/ lgtm

[Ben Goodger (Google), 2015-11-12 17:21:54]

mojo lgtm

[sivag, 2015-11-13 02:43:26]

The CQ bit was checked by siva.gunturi@samsung.com

[commit-bot: I haz the power, 2015-11-13 02:44:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/340001

[commit-bot: I haz the power, 2015-11-13 02:46:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-13 02:46:27]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sivag, 2015-11-15 14:45:56]

The CQ bit was checked by siva.gunturi@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2015-11-15 14:46:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/360001

[sivag, 2015-11-15 15:09:21]

The CQ bit was unchecked by siva.gunturi@samsung.com

[sivag, 2015-11-15 15:09:32]

The CQ bit was checked by siva.gunturi@samsung.com

[sivag, 2015-11-15 15:09:32]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org,
jochen@chromium.org, sievers@chromium.org, ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1385883002/#ps360001
(title: "Rebasing TOT!")

[commit-bot: I haz the power, 2015-11-15 15:09:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385883002/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385883002/360001

[commit-bot: I haz the power, 2015-11-15 16:15:42]

Committed patchset #19 (id:360001)

[commit-bot: I haz the power, 2015-11-15 16:16:40]

Patchset 19 (id:??) landed as
https://crrev.com/5d4feb054523b92862e6e4aca237ca44401fc404
Cr-Commit-Position: refs/heads/master@{#359778}