Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2588)

Unified Diff: docs/v8_committers_responsibility.md

Issue 1385873002: [Docs] Fix some nits discovered while converting to Markdown (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« docs/source.md ('K') | « docs/v8_c_plus_plus_styleand_sops.md ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/v8_committers_responsibility.md
diff --git a/docs/v8_committers_responsibility.md b/docs/v8_committers_responsibility.md
index ee8d21256368bb750282bed29f895ed7f21de1da..c2ff6766f838a6044e882d5a5b7bf31d1ebb260f 100644
--- a/docs/v8_committers_responsibility.md
+++ b/docs/v8_committers_responsibility.md
@@ -1,3 +1,5 @@
+# V8 committer's responsibility
+
## Basic commit guidelines
When you're committing to the V8 repositories, ensure that you follow those guidelines:
@@ -25,17 +27,13 @@ At the same time, we want to encourage many people to participate in the review
So, here are some guidelines to help clarify the process:
1. When a patch author requests more than one reviewer, they should make clear in the review request email what they expect the responsibility of each reviewer to be. For example, you could write this in the email:
-```
-
- a. larry: bitmap changes
- b. sergey: process hacks
- c. everybody else: FYI
-
-```
+ * larry: bitmap changes
+ * sergey: process hacks
+ * everybody else: FYI
1. In this case, you might be on the review list because you've asked to be in the loop for multiprocess changes, but you wouldn't be the primary reviewer and the author and other reviewers wouldn't be expecting you to review all the diffs in detail.
1. If you get a review that includes many other people, and the author didn't do (1), please ask them what part you're responsible for if you don't want to review the whole thing in detail.
1. The author should wait for approval from everybody on the reviewer list before checking in.
1. People who are on a review without clear review responsibility (i.e. drive-by reviews) should be super responsive and not hold up the review. The patch author should feel free to ping them mercilessly if they are.
1. If you're an "FYI" person on a review and you didn't actually review in detail (or at all), but don't have a problem with the patch, note this. You could say something like "rubber stamp" or "ACK" instead of "LGTM." This way the real reviewers know not to trust that you did their work for them, but the author of the patch knows they don't have to wait for further feedback from you. Hopefully we can still keep everybody in the loop but have clear ownership and detailed reviews. It might even speed up some changes since you can quickly "ACK" changes you don't care about, and the author knows they don't have to wait for feedback from you.
-(Adapted from: http://dev.chromium.org/developers/committers-responsibility )
+(Adapted from: http://dev.chromium.org/developers/committers-responsibility )
« docs/source.md ('K') | « docs/v8_c_plus_plus_styleand_sops.md ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698