OLD | NEW |
| 1 # Becoming a V8 committer |
| 2 |
1 ## What is a committer? | 3 ## What is a committer? |
2 | 4 |
3 Technically, a committer is someone who has write access to the V8 SVN repositor
y. A committer can submit his or her own patches or patches from others. | 5 Technically, a committer is someone who has write access to the V8 Git repositor
y. A committer can submit his or her own patches or patches from others. |
4 | 6 |
5 This privilege is granted with some expectation of responsibility: committers ar
e people who care about the V8 project and want to help meet its goals. A commit
ter is not just someone who can make changes, but someone who has demonstrated h
is or her ability to collaborate with the team, get the most knowledgeable peopl
e to review code, contribute high-quality code, and follow through to fix issues
(in code or tests). | 7 This privilege is granted with some expectation of responsibility: committers ar
e people who care about the V8 project and want to help meet its goals. A commit
ter is not just someone who can make changes, but someone who has demonstrated h
is or her ability to collaborate with the team, get the most knowledgeable peopl
e to review code, contribute high-quality code, and follow through to fix issues
(in code or tests). |
6 | 8 |
7 A committer is a contributor to the V8 projects' success and a citizen helping t
he projects succeed. See V8CommittersResponsibility. | 9 A committer is a contributor to the V8 projects' success and a citizen helping t
he projects succeed. See V8CommittersResponsibility. |
8 | 10 |
9 ## How do I become a committer? | 11 ## How do I become a committer? |
10 | 12 |
11 In a nutshell, contribute 20 non-trivial patches and get at least three differen
t people to review them (you'll need three people to support you). Then ask some
one to nominate you. You're demonstrating your: | 13 In a nutshell, contribute 20 non-trivial patches and get at least three differen
t people to review them (you'll need three people to support you). Then ask some
one to nominate you. You're demonstrating your: |
12 | 14 |
13 * commitment to the project (20 good patches requires a lot of your valuable t
ime), | 15 * commitment to the project (20 good patches requires a lot of your valuable t
ime), |
(...skipping 14 matching lines...) Expand all Loading... |
28 Once you get approval from the existing committers, we'll send you instructions
for write access to SVN or Git. You'll also be added to v8-committers@googlegrou
ps.com. | 30 Once you get approval from the existing committers, we'll send you instructions
for write access to SVN or Git. You'll also be added to v8-committers@googlegrou
ps.com. |
29 | 31 |
30 In the worst case, this can drag out for two weeks. Keep writing patches! Even i
n the rare cases where a nomination fails, the objection is usually something ea
sy to address like "more patches" or "not enough people are familiar with this p
erson's work." | 32 In the worst case, this can drag out for two weeks. Keep writing patches! Even i
n the rare cases where a nomination fails, the objection is usually something ea
sy to address like "more patches" or "not enough people are familiar with this p
erson's work." |
31 | 33 |
32 ## Maintaining committer status | 34 ## Maintaining committer status |
33 | 35 |
34 You don't really need to do much to maintain committer status: just keep being a
wesome and helping the V8 project! | 36 You don't really need to do much to maintain committer status: just keep being a
wesome and helping the V8 project! |
35 | 37 |
36 In the unhappy event that a committer continues to disregard good citizenship (o
r actively disrupts the project), we may need to revoke that person's status. Th
e process is the same as for nominating a new committer: someone suggests the re
vocation with a good reason, two people second the motion, and a vote may be cal
led if consensus cannot be reached. I hope that's simple enough, and that we nev
er have to test it in practice. | 38 In the unhappy event that a committer continues to disregard good citizenship (o
r actively disrupts the project), we may need to revoke that person's status. Th
e process is the same as for nominating a new committer: someone suggests the re
vocation with a good reason, two people second the motion, and a vote may be cal
led if consensus cannot be reached. I hope that's simple enough, and that we nev
er have to test it in practice. |
37 | 39 |
38 (Source: inspired by http://dev.chromium.org/getting-involved/become-a-committer
) | 40 (Source: inspired by http://dev.chromium.org/getting-involved/become-a-committer
) |
OLD | NEW |