Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1385873002: [Docs] Fix some nits discovered while converting to Markdown (Closed)

Created:
5 years, 2 months ago by Michael Hablich
Modified:
5 years, 2 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Docs] Fix some nits discovered while converting to Markdown LOG=N R=machenbach@chromium.org Committed: https://crrev.com/17ab6c288ba2b88e9c0c7be3deb75fdb191ca4a2 Cr-Commit-Position: refs/heads/master@{#31101}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -25 lines) Patch
M docs/becoming_v8_committer.md View 2 chunks +4 lines, -2 lines 0 comments Download
M docs/runtime_functions.md View 1 chunk +1 line, -8 lines 0 comments Download
M docs/source.md View 2 chunks +4 lines, -2 lines 2 comments Download
M docs/v8_c_plus_plus_styleand_sops.md View 1 chunk +1 line, -5 lines 0 comments Download
M docs/v8_committers_responsibility.md View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Michael Hablich
PTAL
5 years, 2 months ago (2015-10-05 08:30:50 UTC) #1
Michael Achenbach
lgtm https://codereview.chromium.org/1385873002/diff/1/docs/source.md File docs/source.md (right): https://codereview.chromium.org/1385873002/diff/1/docs/source.md#newcode3 docs/source.md:3: **Quick links:** [browse](https://chromium.googlesource.com/v8/v8/) | [browse bleeding edge](https://chromium.googlesource.com/v8/v8/+/master) | ...
5 years, 2 months ago (2015-10-05 10:08:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385873002/1
5 years, 2 months ago (2015-10-05 14:23:30 UTC) #4
Michael Hablich
https://codereview.chromium.org/1385873002/diff/1/docs/source.md File docs/source.md (right): https://codereview.chromium.org/1385873002/diff/1/docs/source.md#newcode3 docs/source.md:3: **Quick links:** [browse](https://chromium.googlesource.com/v8/v8/) | [browse bleeding edge](https://chromium.googlesource.com/v8/v8/+/master) | [changes](https://chromium.googlesource.com/v8/v8/+log/master). ...
5 years, 2 months ago (2015-10-05 14:24:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 14:47:31 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 14:47:48 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/17ab6c288ba2b88e9c0c7be3deb75fdb191ca4a2
Cr-Commit-Position: refs/heads/master@{#31101}

Powered by Google App Engine
This is Rietveld 408576698