Fix a leak in CPDF_SyntaxParser::GetObject().

Fix a leak in CPDF_SyntaxParser::GetObject().

As seen in FPDFViewEmbeddertest.Crasher_451830.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/a568ff2dddd3ef44f224d21b31afff8eb14b6d31

[Lei Zhang, 2015-10-23 23:57:35]

Description was changed from

==========
Fix a leak in CPDF_SyntaxParser::GetObject().

As seen in FPDFViewEmbeddertest.Crasher_451830.

Also remove some checks for object creation failures. They cannot fail
since all they do is call new. Also reduce nesting in if statements.
==========

to

==========
Fix a leak in CPDF_SyntaxParser::GetObject().

As seen in FPDFViewEmbeddertest.Crasher_451830.
==========

[Lei Zhang, 2015-10-24 00:41:37]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2015-10-24 00:42:25]

Patchset #1 (id:20001) has been deleted

[Lei Zhang, 2015-10-24 00:43:58]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2015-10-24 00:43:59]

https://codereview.chromium.org/1385803002/diff/40001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1385803002/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:2179: if
(keyNoSlash.IsEmpty())
It turns out CFX_CMapByteStringToPtr has a bug where its iterator can't find
items with a key of length 0. @_@.

[Tom Sepez, 2015-10-24 17:04:46]

lgtm

https://codereview.chromium.org/1385803002/diff/40001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1385803002/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:2190:
pDict->SetAt(keyNoSlash, pObj);
nit: One of my favorite lines of code.  Because checking for duplicates in
dictionaries is O(n), don't do it for big dictionaries.  Can you put a fixme
here about removing this once we have a smarter underlying representation for
dictionaries?

[Lei Zhang, 2015-10-26 20:54:23]

https://codereview.chromium.org/1385803002/diff/40001/core/src/fpdfapi/fpdf_p...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1385803002/diff/40001/core/src/fpdfapi/fpdf_p...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:2190:
pDict->SetAt(keyNoSlash, pObj);
On 2015/10/24 17:04:46, Tom Sepez wrote:
> nit: One of my favorite lines of code.  Because checking for duplicates in
> dictionaries is O(n), don't do it for big dictionaries.  Can you put a fixme
> here about removing this once we have a smarter underlying representation for
> dictionaries?

Ah, this smelled fishy. Wasn't sure exactly why.

[Lei Zhang, 2015-10-26 20:54:35]

Committed patchset #3 (id:80001) manually as
a568ff2dddd3ef44f224d21b31afff8eb14b6d31 (presubmit successful).