chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java - Issue 1385663002: [Contextual Search] Add Mojo-enabled API component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

Issue 1385663002: [Contextual Search] Add Mojo-enabled API component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Kausalya's comments, added TODO and bug reference for transition from JS to a better way. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java ('k') | chrome/browser/android/contextualsearch/contextual_search_manager.h » ('j') | chrome/renderer/chrome_content_renderer_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

index b7da20b266ae7e53bf201457264cf565b3ef22d4..93f1369249566b12a7037e87bc770ea4b879cbd9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java

@@ -307,6 +307,13 @@ class ContextualSearchPolicy {

return !isUserUndecided();

}

+ /**

+ * @return Whether Contextual Search should inject its JS into the overlay panel.

+ */

+ boolean shouldInjectJavaScript() {

pedro (no code reviews) 2015/10/20 01:24:41 Maybe calling it shouldProvideJavaScriptAPI would

Donn Denman 2015/10/20 21:56:46 Done.

+ return ContextualSearchFieldTrial.isQuickAnswersEnabled();

+ }

// --------------------------------------------------------------------------------------------

// Testing support.

// --------------------------------------------------------------------------------------------