chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java - Issue 1385663002: [Contextual Search] Add Mojo-enabled API component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

Issue 1385663002: [Contextual Search] Add Mojo-enabled API component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Pedro's comments on naming methods in ContextualSearchApiController. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayContentDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java » ('j') | chrome/renderer/chrome_content_renderer_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

index 3d74cb934588cbd29a339a7ba551c25aa2a8e1b3..1d2aa5523ad0caf2d58b0c9a33b01dd43c319dc3 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

@@ -228,7 +228,7 @@ public class OverlayPanelContent {

private void destroyContentView() {

if (mContentViewCore != null) {

- nativeDestroyWebContents(mNativeOverlayPanelContentPtr);

+ int processId = nativeDestroyWebContents(mNativeOverlayPanelContentPtr);

mContentViewCore.getWebContents().destroy();

mContentViewCore.destroy();

mContentViewCore = null;

@@ -243,7 +243,7 @@ public class OverlayPanelContent {

setVisibility(false);

// After everything has been disposed, notify the observer.

- mContentDelegate.onContentViewDestroyed();

+ mContentDelegate.onContentViewDestroyed(processId);

}

@@ -428,7 +428,7 @@ public class OverlayPanelContent {

long nativeOverlayPanelContent, String historyUrl, long urlTimeMs);

private native void nativeSetWebContents(long nativeOverlayPanelContent,

ContentViewCore contentViewCore, WebContentsDelegateAndroid delegate);

- private native void nativeDestroyWebContents(long nativeOverlayPanelContent);

+ private native int nativeDestroyWebContents(long nativeOverlayPanelContent);

private native void nativeSetInterceptNavigationDelegate(long nativeOverlayPanelContent,

InterceptNavigationDelegate delegate, WebContents webContents);

}