components/contextual_search/common/contextual_search_api_service.mojom - Issue 1385663002: [Contextual Search] Add Mojo-enabled API component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/contextual_search/common/contextual_search_api_service.mojom

Issue 1385663002: [Contextual Search] Add Mojo-enabled API component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Separate component code into browser/common/renderer, and address Jochen's comments. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/contextual_search/browser/contextual_search_api_service_impl.h ('K') | « components/contextual_search/browser/contextual_search_ui_handle.h ('k') | components/contextual_search/common/overlay_page_notifier_service.mojom » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module contextual_search;

	6

	7 // This service is implemented by the browser process and is used by the

	8 // renderer when a Contextual Search JavaScript API function is called.

	9 interface ContextualSearchApiService {
	mdjones 2015/11/19 20:31:24 I would consider adding "js" or "javascript" somew I would consider adding "js" or "javascript" somewhere in this name unless it is to be used for something else; "api" is a little vague. Donn Denman 2015/11/20 00:01:41 I wasn't sure, with everything we went through, th Show quoted text On 2015/11/19 20:31:24, mdjones wrote: > I would consider adding "js" or "javascript" somewhere in this name unless it is > to be used for something else; "api" is a little vague. I wasn't sure, with everything we went through, that the API would actually BE done in JS. But now I think we do have some confidence on that, so I'll take your suggestion.
	10

	11 // Handle a call from the JS API to set the caption.

	12 HandleSetCaption(string message);

	13 };

OLD	NEW