components/contextual_search/OWNERS - Issue 1385663002: [Contextual Search] Add Mojo-enabled API component.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/contextual_search/OWNERS

Issue 1385663002: [Contextual Search] Add Mojo-enabled API component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reworked to use a new Contextual Search component and Mojo communication, removed CS Manager stuff. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/contextual_search/DEPS ('K') | « components/contextual_search/DEPS ('k') | components/contextual_search/README » ('j') | components/contextual_search/contextual_search_api_service_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 aurimas@chromium.org

2 donnd@chromium.org	1 donnd@chromium.org

3 pedrosimonetti@chromium.org	2 pedrosimonetti@chromium.org
	jochen (gone - plz use gerrit) 2015/11/17 14:58:11 only chromium committers can be in owners files only chromium committers can be in owners files Donn Denman 2015/11/19 01:11:29 Pedro and I are both new Chromium committers. Show quoted text On 2015/11/17 14:58:11, jochen wrote: > only chromium committers can be in owners files Pedro and I are both new Chromium committers.
	3 twellington@chromium.org
	jochen (gone - plz use gerrit) 2015/11/17 14:58:11 please add a per-file rule for the .mojom restric please add a per-file rule for the .mojom restricting it to ipc reviewers: # Changes to Mojo interfaces require a security review to avoid # introducing new sandbox escapes. per-file .mojom=set noparent per-file .mojom=palmer@chromium.org per-file .mojom=tsepez@chromium.org Donn Denman* 2015/11/19 01:11:29 Done. Show quoted text On 2015/11/17 14:58:11, jochen wrote: > please add a per-file rule for the .mojom restricting it to ipc reviewers: > > # Changes to Mojo interfaces require a security review to avoid > # introducing new sandbox escapes. > per-file .mojom=set noparent > per-file mailto:.mojom=palmer@chromium.org > per-file mailto:.mojom=tsepez@chromium.org Done.
OLD	NEW