Issue 1385653002: apply_issue: actually catch exception during patch download.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1385653002: apply_issue: actually catch exception during patch download. (Closed)

Created:
5 years, 2 months ago by tandrii(chromium)

Modified:
5 years, 2 months ago

Reviewers:
Sergiy Byelozyorov, Paweł Hajdan Jr.

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

apply_issue: actually catch exception during patch download. R=sergiyb@chromium.org,phajdan.jr@chromium.org BUG=537417 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296986

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	apply_issue.py	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tandrii(chromium)

PTAL Reason: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/115727/steps/bot_update/logs/patch%20error

5 years, 2 months ago (2015-10-02 14:56:54 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385653002/1

5 years, 2 months ago (2015-10-02 15:00:40 UTC) #4

commit-bot: I haz the power

5 years, 2 months ago (2015-10-02 15:02:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296986

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages