Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1755)

Issue 138563004: Move macros from TestClassDef.h to Test.h (Closed)

Created:
6 years, 11 months ago by hal.canary
Modified:
6 years, 11 months ago
Reviewers:
tfarina, mtklein
CC:
skia-review_googlegroups.com, tfarina
Visibility:
Public.

Description

Move macros from TestClassDef.h to Test.h Motivation: those macros don't make any sense without the definitions in Test.h. BUG= Committed: http://code.google.com/p/skia/source/detail?r=13074

Patch Set 1 : upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -216 lines) Patch
tests/AAClipTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ARGBImageEncoderTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/AndroidPaintTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/AnnotationTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/AtomicTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/BitSetTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/BitmapCopyTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/BitmapGetColorTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/BitmapHasherTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/BitmapHeapTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/BitmapTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/BlitRowTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/BlurTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/CanvasStateTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ChecksumTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ClampRangeTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/ClipCacheTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ClipCubicTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/ClipStackTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ClipperTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ColorFilterTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/ColorPrivTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ColorTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/DataRefTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/DeferredCanvasTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/DequeTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/DeviceLooperTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/DiscardableMemoryPool.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/DiscardableMemoryTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/DocumentTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/DrawPathTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/DrawTextTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/DynamicHashTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/EmptyPathTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/ErrorTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/FillPathTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/FitsInTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/FlatDataTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/FlateTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/FontHostStreamTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/FontHostTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/FontMgrTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/FontNamesTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/FrontBufferedStreamTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/GLInterfaceValidation.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/GeometryTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/GifTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/GpuBitmapCopyTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/GpuColorFilterTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/GpuDrawPathTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/GrContextFactoryTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/GrDrawTargetTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/GrMemoryPoolTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/GrSurfaceTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/GrUnitTests.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/GradientTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/HashCacheTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/ImageCacheTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/ImageDecodingTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/InfRectTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/JpegTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/LListTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/LayerDrawLooperTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/MD5Test.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/MallocPixelRefTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/MathTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/Matrix44Test.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/MatrixTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/MemoryTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/MemsetTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/MessageBusTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/MetaDataTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/MipMapTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/OSPathTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/OnceTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PDFPrimitivesTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PackBitsTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PaintTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/ParsePathTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PathCoverageTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PathMeasureTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PathOpsAngleTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PathOpsBoundsTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PathOpsCubicIntersectionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsCubicLineIntersectionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsCubicQuadIntersectionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PathOpsCubicReduceOrderTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PathOpsCubicToQuadsTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsDCubicTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsDLineTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsDPointTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsDQuadTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsDRectTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsDTriangleTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsDVectorTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsInverseTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsLineIntersectionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsLineParametetersTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsOpCubicThreadedTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsOpRectThreadedTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsQuadIntersectionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsQuadLineIntersectionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsQuadLineIntersectionThreadedTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsQuadParameterizationTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsQuadReduceOrderTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsSimplifyDegenerateThreadedTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsSimplifyFailTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsSimplifyQuadThreadedTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsSimplifyQuadralateralsThreadedTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsSimplifyRectThreadedTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsSimplifyTrianglesThreadedTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsSkpTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PathOpsTypesTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PathTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PathUtilsTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PictureTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/PictureUtilsTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PipeTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PixelRefTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PointTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/PremulAlphaRoundTripTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/QuickRejectTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/RTreeTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/RandomTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/ReadPixelsTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/ReadWriteAlphaTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/Reader32Test.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/RefCntTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/RefDictTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/RegionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/ResourceCacheTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/RoundRectTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/RuntimeConfigTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/SHA1Test.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/ScalarTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/SerializationTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/ShaderImageFilterTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ShaderOpacityTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/SkpSkGrTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/SortTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/SrcOverTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/StreamTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/StringTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/StrokeTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/SurfaceTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/TDStackNesterTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/TLSTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/TSetTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/Test.h View 2 chunks +54 lines, -1 line 0 comments Download
D tests/TestClassDef.h View 1 chunk +0 lines, -48 lines 0 comments Download
tests/TestSize.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/TileGridTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/ToUnicode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/Typeface.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/UnicodeTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/UnitTestTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/UtilsTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/WArrayTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/WritePixelsTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/Writer32Test.cpp View 1 chunk +0 lines, -1 line 0 comments Download
tests/XfermodeTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
hal.canary
ptal
6 years, 11 months ago (2014-01-14 20:25:38 UTC) #1
mtklein
lgtm
6 years, 11 months ago (2014-01-14 20:41:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/138563004/30001
6 years, 11 months ago (2014-01-14 20:46:00 UTC) #3
commit-bot: I haz the power
Change committed as 13074
6 years, 11 months ago (2014-01-14 21:05:23 UTC) #4
tfarina
I have talked to Mike about this over email. I told him I was working ...
6 years, 11 months ago (2014-01-15 00:04:07 UTC) #5
mtklein
On 2014/01/15 00:04:07, tfarina wrote: > I have talked to Mike about this over email. ...
6 years, 11 months ago (2014-01-15 01:32:38 UTC) #6
hal.canary
6 years, 11 months ago (2014-01-15 13:00:08 UTC) #7
Message was sent while issue was closed.
I would not have written the change if I knew you were working on it.  In fact,
your changes to simplify the test macros inspired me!

Powered by Google App Engine
This is Rietveld 408576698