Issue 138563003: Datadump on sync_internals output REDACTED instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138563003: Datadump on sync_internals output REDACTED instead (Closed)

Created:
6 years, 11 months ago by mferreria

Modified:
6 years, 10 months ago

Reviewers:
rlarocque

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Datadump on sync_internals output REDACTED instead When the user request sync events dump on the sync_internals page, he can check a box to say if he wants to dump also the node content. If he doesn't check it, then the node is not stringyfied and it returns a "[Object object]" message. This changes this behaviour and replaces the message with a "REDACTED", that looks better on the .csv file and makes it clear that the user requested this option, insted of being a stringyfier or any other bug. BUG=333365 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245173

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/resources/sync_internals/data.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mferreria@google.com/138563003/1

6 years, 11 months ago (2014-01-14 19:32:36 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mferreria@google.com/138563003/1

6 years, 11 months ago (2014-01-15 00:17:58 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mferreria@google.com/138563003/1

6 years, 11 months ago (2014-01-15 05:10:28 UTC) #5

Message was sent while issue was closed.

Change committed as 245173

Expand Messages | Collapse Messages