Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1385623002: [Interpreter]: Add support for strict mode load / store ICs. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter]: Add support for strict mode load / store ICs. Adds support for strict mode load / store ICs and cleans up BinaryOp and CompareOp to only trigger an UNIMPLEMENTED abort if called with STRONG mode (which is the only language mode which has different compare/binary ops. BUG=v8:4280 LOG=N Committed: https://crrev.com/785516821de1d89320c26bdb3849173a1410abd2 Cr-Commit-Position: refs/heads/master@{#31134}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Review comments. #

Patch Set 3 : Rebase #

Patch Set 4 : Fix gcc error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+488 lines, -262 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 2 1 chunk +28 lines, -4 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 2 3 3 chunks +7 lines, -2 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 2 3 7 chunks +82 lines, -25 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M src/interpreter/bytecodes.h View 1 2 2 chunks +73 lines, -67 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 2 2 chunks +64 lines, -16 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 2 13 chunks +180 lines, -107 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 2 14 chunks +21 lines, -20 lines 0 comments Download
M test/unittests/compiler/bytecode-graph-builder-unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 2 1 chunk +20 lines, -16 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-iterator-unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (10 generated)
rmcilroy
mvstanton: please take a look at IC calls. oth: please take a look at interpreter ...
5 years, 2 months ago (2015-10-02 13:41:56 UTC) #2
oth
interpreter lgtm. optional nit. https://codereview.chromium.org/1385623002/diff/1/src/interpreter/bytecode-array-builder.cc File src/interpreter/bytecode-array-builder.cc (right): https://codereview.chromium.org/1385623002/diff/1/src/interpreter/bytecode-array-builder.cc#newcode133 src/interpreter/bytecode-array-builder.cc:133: UNIMPLEMENTED(); Nitletino - other updates ...
5 years, 2 months ago (2015-10-02 15:17:44 UTC) #4
Michael Starzinger
LGTM, just nits. https://codereview.chromium.org/1385623002/diff/1/src/interpreter/bytecode-array-builder.cc File src/interpreter/bytecode-array-builder.cc (right): https://codereview.chromium.org/1385623002/diff/1/src/interpreter/bytecode-array-builder.cc#newcode243 src/interpreter/bytecode-array-builder.cc:243: UNIMPLEMENTED(); nit: The strong case is ...
5 years, 2 months ago (2015-10-05 12:04:45 UTC) #5
rmcilroy
Updated with review comments. https://codereview.chromium.org/1385623002/diff/1/src/interpreter/bytecode-array-builder.cc File src/interpreter/bytecode-array-builder.cc (right): https://codereview.chromium.org/1385623002/diff/1/src/interpreter/bytecode-array-builder.cc#newcode133 src/interpreter/bytecode-array-builder.cc:133: UNIMPLEMENTED(); On 2015/10/02 15:17:44, oth ...
5 years, 2 months ago (2015-10-06 13:56:34 UTC) #6
oth
On 2015/10/06 13:56:34, rmcilroy wrote: > Updated with review comments. > > https://codereview.chromium.org/1385623002/diff/1/src/interpreter/bytecode-array-builder.cc > File ...
5 years, 2 months ago (2015-10-06 14:08:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385623002/20001
5 years, 2 months ago (2015-10-06 14:16:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/8480) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 2 months ago (2015-10-06 14:17:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385623002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385623002/40001
5 years, 2 months ago (2015-10-06 14:25:14 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/6987)
5 years, 2 months ago (2015-10-06 14:29:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385623002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385623002/60001
5 years, 2 months ago (2015-10-07 07:31:22 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-07 07:54:13 UTC) #21
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/785516821de1d89320c26bdb3849173a1410abd2 Cr-Commit-Position: refs/heads/master@{#31134}
5 years, 2 months ago (2015-10-07 07:54:38 UTC) #22
mvstanton
5 years, 2 months ago (2015-10-07 09:11:45 UTC) #23
Message was sent while issue was closed.
Sorry to be late on this one.
IC calls look okay, lgtm.

Powered by Google App Engine
This is Rietveld 408576698