Issue 13856017: Fix a bug in SkTextBox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13856017: Fix a bug in SkTextBox. (Closed)

Created:
7 years, 8 months ago by scroggo

Modified:
7 years, 8 months ago

Reviewers:
bungeman, bungeman-skia

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix a bug in SkTextBox. When checking to see if the line of text is beyond the bottom of the textbox, compare with the bottom, rather than the height (bottom - top). Prior to this change, text in the bottom of a textbox could be clipped out. BUG=https://code.google.com/p/skia/issues/detail?id=1250 Committed: https://code.google.com/p/skia/source/detail?r=8838

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/views/SkTextBox.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scroggo

7 years, 8 months ago (2013-04-24 14:11:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r8838 (presubmit successful).

Expand Messages | Collapse Messages