Try to avoid GCC strict-aliasing error

runtime/bin/socket_linux.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_LINUX)
 
 #include <errno.h>  // NOLINT
 #include <stdio.h>  // NOLINT
 #include <stdlib.h>  // NOLINT
 #include <string.h>  // NOLINT
 #include <sys/stat.h>  // NOLINT
 #include <unistd.h>  // NOLINT
 #include <netinet/tcp.h>  // NOLINT
 
 #include "bin/fdutils.h"
 #include "bin/file.h"
 #include "bin/log.h"
 #include "bin/socket.h"
 
 
-#define SOCKADDR_STORAGE_SET_PORT(addr, port) \
-    if (addr.ss_family == AF_INET) { \
-      reinterpret_cast<struct sockaddr_in*>(&addr)->sin_port = htons(port); \
-    } else { \
-      reinterpret_cast<struct sockaddr_in6*>(&addr)->sin6_port = htons(port); \
-    }
-
-
 #define SOCKADDR_STORAGE_GET_PORT(addr) \
     addr.ss_family == AF_INET ? \
     ntohs(reinterpret_cast<struct sockaddr_in*>(&addr)->sin_port) : \
     ntohs(reinterpret_cast<struct sockaddr_in6*>(&addr)->sin6_port)
 
 
+static void SetPort(sockaddr_storage* addr, int port) {
+  char* ptr = reinterpret_cast<char*>(addr);
+  if (addr->ss_family == AF_INET) {
+    reinterpret_cast<struct sockaddr_in*>(ptr)->sin_port = htons(port);
+  } else { \
+    reinterpret_cast<struct sockaddr_in6*>(ptr)->sin6_port = htons(port);
+  }
+}
+
+
 SocketAddress::SocketAddress(struct addrinfo* addrinfo) {
   ASSERT(INET6_ADDRSTRLEN >= INET_ADDRSTRLEN);
   sockaddr_in *sockaddr = reinterpret_cast<sockaddr_in *>(addrinfo->ai_addr);
   const char* result = inet_ntop(addrinfo->ai_family,
                                  &sockaddr->sin_addr,
                                  as_string_,
                                  INET6_ADDRSTRLEN);
   if (result == NULL) as_string_[0] = 0;
   memmove(reinterpret_cast<void *>(&addr_),
           addrinfo->ai_addr,
@@ skipping 12 matching lines @@
 
   fd = TEMP_FAILURE_RETRY(socket(addr.ss_family, SOCK_STREAM, 0));
   if (fd < 0) {
     Log::PrintErr("Error CreateConnect: %s\n", strerror(errno));
     return -1;
   }
 
   FDUtils::SetCloseOnExec(fd);
   Socket::SetNonBlocking(fd);
 
-  SOCKADDR_STORAGE_SET_PORT(addr, port);
+  SetPort(&addr, port);
   intptr_t result = TEMP_FAILURE_RETRY(
       connect(fd,
               reinterpret_cast<struct sockaddr*>(&addr),
               SocketAddress::GetAddrLength(addr)));
   if (result == 0 || errno == EINPROGRESS) {
     return fd;
   }
   TEMP_FAILURE_RETRY(close(fd));
   return -1;
 }
@@ skipping 154 matching lines @@
   int optval = 1;
   TEMP_FAILURE_RETRY(
       setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &optval, sizeof(optval)));
 
   if (addr.ss_family == AF_INET6) {
     optval = 0;
     TEMP_FAILURE_RETRY(
         setsockopt(fd, IPPROTO_IPV6, IPV6_V6ONLY, &optval, sizeof(optval)));
   }
 
-  SOCKADDR_STORAGE_SET_PORT(addr, port);
+  SetPort(&addr, port);
   if (TEMP_FAILURE_RETRY(
           bind(fd,
                reinterpret_cast<struct sockaddr*>(&addr),
                SocketAddress::GetAddrLength(addr))) < 0) {
     TEMP_FAILURE_RETRY(close(fd));
     return -1;
   }
 
   if (TEMP_FAILURE_RETRY(listen(fd, backlog > 0 ? backlog : SOMAXCONN)) != 0) {
     TEMP_FAILURE_RETRY(close(fd));
@@ skipping 60 matching lines @@
 bool Socket::SetNoDelay(intptr_t fd, bool enabled) {
   int on = enabled ? 1 : 0;
   return TEMP_FAILURE_RETRY(setsockopt(fd,
                                        SOL_TCP,
                                        TCP_NODELAY,
                                        reinterpret_cast<char *>(&on),
                                        sizeof(on))) == 0;
 }
 
 #endif  // defined(TARGET_OS_LINUX)