Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 13856011: Relax --debug-code checks that runtime returns are not the hole (Closed)

Created:
7 years, 8 months ago by wingo
Modified:
7 years, 8 months ago
Reviewers:
Michael Starzinger
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Relax --debug-code checks that runtime returns are not the hole ia32, unlike the other architectures, includes a --debug-code check that asserts that runtime functions do not return the hole. However the new SuspendJSGeneratorObject runtime does return the hole at times. This CL adds a wee hack that only signals an error if the callee was not SuspendJSGeneratorObject. R=mstarzinger@chromium.org BUG= Committed: http://code.google.com/p/v8/source/detail?r=14437

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add TODO to remove hack. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/ia32/code-stubs-ia32.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
wingo
7 years, 8 months ago (2013-04-23 08:34:49 UTC) #1
Michael Starzinger
LGTM with a comment. I'll land this one comment is addressed. https://codereview.chromium.org/13856011/diff/1/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): ...
7 years, 8 months ago (2013-04-25 10:39:57 UTC) #2
wingo
Updated patch adds TODO at the site of the hack.
7 years, 8 months ago (2013-04-25 10:54:03 UTC) #3
Michael Starzinger
7 years, 8 months ago (2013-04-25 12:00:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r14437 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698