Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 138553004: Move component updater artifacts into component_updater namespace. (Closed)

Created:
6 years, 11 months ago by Sorin Jianu
Modified:
6 years, 11 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Move component updater artifacts into component_updater namespace. sky@ please look at the files in chrome/browser for owner approval. Long term, the idea is to unify several updaters in Chrome, so having a specific namespace could help avoiding name conflicts. Short term, the change reduces some naming verbosity in the implementation but makes the call site names longer, so it is a wash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245596

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : #

Patch Set 4 : Fixed friend decl #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -78 lines) Patch
M chrome/browser/browser_process.h View 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 2 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 chunks +10 lines, -6 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/component_updater/component_patcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/component_patcher.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/component_patcher_operation.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/component_patcher_operation.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/component_patcher_win.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/component_patcher_win.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/component_unpacker.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/component_unpacker.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/component_updater_configurator.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/component_updater_configurator.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/component_updater_ping_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_service.h View 1 2 3 5 4 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/component_updater_service.cc View 13 chunks +21 lines, -24 lines 0 comments Download
M chrome/browser/component_updater/component_updater_utils.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/crx_update_item.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/default_component_installer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/default_component_installer.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/flash_component_installer.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_profile_observer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_profile_observer.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/recovery_component_installer.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/component_updater/recovery_component_installer.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/swiftshader_component_installer.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/test/component_installers_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/test/component_patcher_mock.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/test/component_patcher_unittest.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/test/component_patcher_unittest.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/test/component_updater_service_unittest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/component_updater/test/test_installer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/test/test_installer.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/test/update_checker_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/update_checker.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/net/crl_set_fetcher.h View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/net/crl_set_fetcher.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/components_ui.cc View 4 5 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cpu_(ooo_6.6-7.5)
lgtm on the component_updater folder unless the changes become non-mechanical name adding/removal.
6 years, 11 months ago (2014-01-16 01:55:09 UTC) #1
Sorin Jianu
Sky@, please look at files chrome/browser for an owner approval. Thank you!
6 years, 11 months ago (2014-01-17 02:48:24 UTC) #2
sky
c/b LGTM
6 years, 11 months ago (2014-01-17 15:54:32 UTC) #3
waffles
lgtm
6 years, 11 months ago (2014-01-17 18:33:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/138553004/290001
6 years, 11 months ago (2014-01-17 18:38:08 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 20:22:36 UTC) #6
Message was sent while issue was closed.
Change committed as 245596

Powered by Google App Engine
This is Rietveld 408576698