Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 138553003: Break HarfBuzzShaper::collectHarfBuzzRuns apart (Closed)

Created:
6 years, 11 months ago by eae
Modified:
6 years, 11 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Visibility:
Public.

Description

Break HarfBuzzShaper::collectHarfBuzzRuns apart Break out the handling of GC_M_MASK (multiple uchar category) into separate inline function as a part of the effort to clean up the logic to allow proper handling of script_common. BUG=311372 R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -17 lines) Patch
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp View 2 chunks +31 lines, -17 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eae
6 years, 11 months ago (2014-01-15 00:09:49 UTC) #1
leviw_travelin_and_unemployed
LGTM. I was hoping you'd add some more nested loops, but I guess you can ...
6 years, 11 months ago (2014-01-15 00:23:51 UTC) #2
eae
On 2014/01/15 00:23:51, Levi wrote: > LGTM. I was hoping you'd add some more nested ...
6 years, 11 months ago (2014-01-15 00:24:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/138553003/1
6 years, 11 months ago (2014-01-15 00:32:00 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 09:47:43 UTC) #5
Message was sent while issue was closed.
Change committed as 165115

Powered by Google App Engine
This is Rietveld 408576698