Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: pkg/analysis_server/tool/spec/generated/java/types/AnalysisError.java

Issue 1385523002: AnalysisError `hasFix` attr (Implements #23874). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Doc typo fix. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/protocol_server_test.dart ('k') | pkg/analysis_server/tool/spec/spec_input.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/tool/spec/generated/java/types/AnalysisError.java
diff --git a/pkg/analysis_server/tool/spec/generated/java/types/AnalysisError.java b/pkg/analysis_server/tool/spec/generated/java/types/AnalysisError.java
index c85d882d53b9ea2ba272578b5881c7830b20dd51..baf27c0868bc0dc7af282ed150f067616245e8b8 100644
--- a/pkg/analysis_server/tool/spec/generated/java/types/AnalysisError.java
+++ b/pkg/analysis_server/tool/spec/generated/java/types/AnalysisError.java
@@ -72,14 +72,26 @@ public class AnalysisError {
private final String correction;
/**
+ * A hint to indicate to interested clients that this error has an associated fix (or fixes). The
+ * absence of this field implies there are not known to be fixes. Note that since the operation to
+ * calculate whether fixes apply needs to be performant it is possible that complicated tests will
+ * be skipped and a false negative returned. For this reason, this attribute should be treated as a
+ * "hint". Despite the possibility of false negatives, no false positives should be returned. If a
+ * client sees this flag set they can proceed with the confidence that there are in fact associated
+ * fixes.
+ */
+ private final Boolean hasFix;
+
+ /**
* Constructor for {@link AnalysisError}.
*/
- public AnalysisError(String severity, String type, Location location, String message, String correction) {
+ public AnalysisError(String severity, String type, Location location, String message, String correction, Boolean hasFix) {
this.severity = severity;
this.type = type;
this.location = location;
this.message = message;
this.correction = correction;
+ this.hasFix = hasFix;
}
@Override
@@ -91,7 +103,8 @@ public class AnalysisError {
ObjectUtilities.equals(other.type, type) &&
ObjectUtilities.equals(other.location, location) &&
ObjectUtilities.equals(other.message, message) &&
- ObjectUtilities.equals(other.correction, correction);
+ ObjectUtilities.equals(other.correction, correction) &&
+ ObjectUtilities.equals(other.hasFix, hasFix);
}
return false;
}
@@ -102,7 +115,8 @@ public class AnalysisError {
Location location = Location.fromJson(jsonObject.get("location").getAsJsonObject());
String message = jsonObject.get("message").getAsString();
String correction = jsonObject.get("correction") == null ? null : jsonObject.get("correction").getAsString();
- return new AnalysisError(severity, type, location, message, correction);
+ Boolean hasFix = jsonObject.get("hasFix") == null ? null : jsonObject.get("hasFix").getAsBoolean();
+ return new AnalysisError(severity, type, location, message, correction, hasFix);
}
public static List<AnalysisError> fromJsonArray(JsonArray jsonArray) {
@@ -127,6 +141,19 @@ public class AnalysisError {
}
/**
+ * A hint to indicate to interested clients that this error has an associated fix (or fixes). The
+ * absence of this field implies there are not known to be fixes. Note that since the operation to
+ * calculate whether fixes apply needs to be performant it is possible that complicated tests will
+ * be skipped and a false negative returned. For this reason, this attribute should be treated as a
+ * "hint". Despite the possibility of false negatives, no false positives should be returned. If a
+ * client sees this flag set they can proceed with the confidence that there are in fact associated
+ * fixes.
+ */
+ public Boolean getHasFix() {
+ return hasFix;
+ }
+
+ /**
* The location associated with the error.
*/
public Location getLocation() {
@@ -163,6 +190,7 @@ public class AnalysisError {
builder.append(location);
builder.append(message);
builder.append(correction);
+ builder.append(hasFix);
return builder.toHashCode();
}
@@ -175,6 +203,9 @@ public class AnalysisError {
if (correction != null) {
jsonObject.addProperty("correction", correction);
}
+ if (hasFix != null) {
+ jsonObject.addProperty("hasFix", hasFix);
+ }
return jsonObject;
}
@@ -191,7 +222,9 @@ public class AnalysisError {
builder.append("message=");
builder.append(message + ", ");
builder.append("correction=");
- builder.append(correction);
+ builder.append(correction + ", ");
+ builder.append("hasFix=");
+ builder.append(hasFix);
builder.append("]");
return builder.toString();
}
« no previous file with comments | « pkg/analysis_server/test/protocol_server_test.dart ('k') | pkg/analysis_server/tool/spec/spec_input.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698