Add --threads to tests binary, to run non-GPU tests on multiple cores.

tests/skia_test.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkCommandLineFlags.h"
 #include "SkGraphics.h"
+#include "SkRunnable.h"
+#include "SkThreadPool.h"
+#include "SkTArray.h"
+#include "SkTScopedPtr.h"
 #include "Test.h"
 #include "SkOSFile.h"
 
 #if SK_SUPPORT_GPU
 #include "GrContext.h"
 #endif
 
 using namespace skiatest;
 
 // need to explicitly declare this, or we get some weird infinite loop llist
@@ skipping 36 matching lines @@
     const TestRegistry* fReg;
 };
 
 static const char* result2string(Reporter::Result result) {
     return result == Reporter::kPassed ? "passed" : "FAILED";
 }
 
 class DebugfReporter : public Reporter {
 public:
     DebugfReporter(bool allowExtendedTest)
-        : fIndex(0)
+        : fNextIndex(0)
         , fTotal(0)
         , fAllowExtendedTest(allowExtendedTest) {
     }
 
-    void setIndexOfTotal(int index, int total) {
-        fIndex = index;
+    void setTotal(int total) {
         fTotal = total;
     }
 
     virtual bool allowExtendedTest() const {
         return fAllowExtendedTest;
     }
 
 protected:
     virtual void onStart(Test* test) {
-        SkDebugf("[%d/%d] %s...\n", fIndex+1, fTotal, test->getName());
+        const int index = sk_atomic_inc(&fNextIndex);
+        SkDebugf("[%d/%d] %s...\n", index+1, fTotal, test->getName());
     }
     virtual void onReport(const char desc[], Reporter::Result result) {
         SkDebugf("\t%s: %s\n", result2string(result), desc);
     }
-    virtual void onEnd(Test*) {
-        if (!this->getCurrSuccess()) {
-            SkDebugf("---- FAILED\n");
+
+    virtual void onEnd(Test* test) {
+        if (!test->passed()) {
+          SkDebugf("---- FAILED\n");
         }
     }
+
 private:
-    int fIndex, fTotal;
+    int fNextIndex, fTotal;
     bool fAllowExtendedTest;
 };
 
 static const char* make_canonical_dir_path(const char* path, SkString* storage) {
     if (path) {
         // clean it up so it always has a trailing searator
         size_t len = strlen(path);
         if (0 == len) {
             path = NULL;
         } else if (SkPATH_SEPARATOR != path[len - 1]) {
@@ skipping 16 matching lines @@
 
 const SkString& Test::GetResourcePath() {
     return gResourcePath;
 }
 
 DEFINE_string2(match, m, NULL, "substring of test name to run.");
 DEFINE_string2(tmpDir, t, NULL, "tmp directory for tests to use.");
 DEFINE_string2(resourcePath, i, NULL, "directory for test resources.");
 DEFINE_bool2(extendedTest, x, false, "run extended tests for pathOps.");
 DEFINE_bool2(verbose, v, false, "enable verbose output.");
+DEFINE_int32(threads, 8,
+             "If >0, run threadsafe tests on a threadpool with this many threads.");
+
+// Deletes self when run.
+class SkTestRunnable : public SkRunnable {
+public:
+  // Takes ownership of test.
+  SkTestRunnable(Test* test, int* failCount) : fTest(test), fFailCount(failCount) {}
+
+  virtual void run() {
+      fTest->run();
+      if(!fTest->passed()) {
+          sk_atomic_inc(fFailCount);
+      }
+      SkDELETE(this);
+  }
+
+private:
+    SkTScopedPtr<Test> fTest;
+    int* fFailCount;

[scroggo, 2013/04/17 17:34:52]

Shouldn't this be int32_t since it's passed to sk_atomic_inc?

[mtklein, 2013/04/17 18:13:59]

Done.

+};
 
 int tool_main(int argc, char** argv);
 int tool_main(int argc, char** argv) {
     SkCommandLineFlags::SetUsage("");
     SkCommandLineFlags::Parse(argc, argv);
 
     if (!FLAGS_tmpDir.isEmpty()) {
         make_canonical_dir_path(FLAGS_tmpDir[0], &gTmpDir);
     }
     if (!FLAGS_resourcePath.isEmpty()) {
@@ skipping 25 matching lines @@
 #ifdef SK_SCALAR_IS_FIXED
         header.append(" SK_SCALAR_IS_FIXED");
 #else
         header.append(" SK_SCALAR_IS_FLOAT");
 #endif
         SkDebugf("%s\n", header.c_str());
     }
 
     DebugfReporter reporter(FLAGS_extendedTest);
     Iter iter(&reporter);
-    Test* test;
 
     const int count = Iter::Count();
-    int index = 0;
+    reporter.setTotal(count);
     int failCount = 0;

[scroggo, 2013/04/17 17:34:52]

int32_t?

[mtklein, 2013/04/17 18:13:59]

Done.

     int skipCount = 0;
-    while ((test = iter.next()) != NULL) {
-        reporter.setIndexOfTotal(index, count);
+
+    SkTScopedPtr<SkThreadPool> threadpool(SkNEW_ARGS(SkThreadPool, (FLAGS_threads)));
+    SkTArray<Test*> unsafeTests;  // Always passes ownership to an SkTestRunnable
+    for (int i = 0; i < count; i++) {
+        SkTScopedPtr<Test> test(iter.next());
         if (!FLAGS_match.isEmpty() && !strstr(test->getName(), FLAGS_match[0])) {
             ++skipCount;
+        } else if (!test->isThreadsafe()) {
+            unsafeTests.push_back() = test.release();
         } else {
-            if (!test->run()) {
-                ++failCount;
-            }
+            threadpool->add(SkNEW_ARGS(SkTestRunnable, (test.release(), &failCount)));
         }
-        SkDELETE(test);
-        index += 1;
     }
 
+    // Run the tests that aren't threadsafe.
+    for (int i = 0; i < unsafeTests.count(); i++) {
+        SkNEW_ARGS(SkTestRunnable, (unsafeTests[i], &failCount))->run();

[scroggo, 2013/04/17 17:34:52]

Won't the destructor for SkTArray call the destructor for each unsafeTest, even
though the SkTestRunnable deleted it?

[mtklein, 2013/04/17 18:13:59]

This is an SkTArray<Test*>.  Does SkTArray delete pointer values?  That'd be
pretty surprising.

+    }
+
+    // Blocks until threaded tests finish.
+    threadpool.reset();
+
     SkDebugf("Finished %d tests, %d failures, %d skipped.\n",
              count, failCount, skipCount);
     int testCount = reporter.countTests();
     if (FLAGS_verbose && testCount > 0) {
         SkDebugf("Ran %d Internal tests.\n", testCount);
     }
 #if SK_SUPPORT_GPU
 
 #if GR_CACHE_STATS
     GrContext *gr = GpuTest::GetContext();
 
     gr->printCacheStats();
 #endif
 
 #endif
 
     SkGraphics::Term();
     GpuTest::DestroyContexts();
 
     return (failCount == 0) ? 0 : 1;
 }
 
 #if !defined(SK_BUILD_FOR_IOS) && !defined(SK_BUILD_FOR_NACL)
 int main(int argc, char * const argv[]) {
     return tool_main(argc, (char**) argv);
 }
 #endif