Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1385463002: Update Android toolchains and streamline process. (Closed)

Created:
5 years, 2 months ago by mtklein_C
Modified:
5 years, 2 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update Android toolchains and streamline process. - This updates to r10e / API v21 everywhere. - This has each host machine fetch the NDK, run make-standalone-toolchain.sh, and copy gdbserver itself. (It will do all this once per $ARCH, which is a little inefficient, but it washes out in steady state.) BUG=skia: Committed: https://skia.googlesource.com/skia/+/e14937e7c458418edcf0a87dd4dd065457d8a8d1

Patch Set 1 #

Patch Set 2 : ANDROID_ARCH #

Patch Set 3 : 14 for 32-bit, 21 for 64-bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -49 lines) Patch
D platform_tools/android/bin/download_toolchains.py View 1 chunk +0 lines, -19 lines 0 comments Download
M platform_tools/android/bin/utils/setup_toolchain.sh View 1 2 1 chunk +24 lines, -30 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385463002/1
5 years, 2 months ago (2015-10-01 19:40:19 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/2754)
5 years, 2 months ago (2015-10-01 19:42:31 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385463002/20001
5 years, 2 months ago (2015-10-01 19:48:11 UTC) #6
mtklein_C
5 years, 2 months ago (2015-10-01 19:52:51 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 19:54:44 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385463002/40001
5 years, 2 months ago (2015-10-01 20:09:54 UTC) #12
mtklein_C
ptal
5 years, 2 months ago (2015-10-01 20:16:24 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 20:16:27 UTC) #15
djsollen
lgtm
5 years, 2 months ago (2015-10-01 20:22:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385463002/40001
5 years, 2 months ago (2015-10-01 20:23:48 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 20:24:25 UTC) #19
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e14937e7c458418edcf0a87dd4dd065457d8a8d1

Powered by Google App Engine
This is Rietveld 408576698