Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1385443002: [Swarming] Presort tests - slowest first. (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Swarming] Presort tests - slowest first. Swarming won't support an incremental data file. By just sorting the lowest hanging fruits to the beginning we already get a big bang for the buck (>80% of the improvement we get otherwise). This will require semi-regular manual updates of the slowest tests. BUG=chromium:535160 LOG=n Committed: https://crrev.com/366dc81143d2b2d4f58a4974ae528f081b05690b Cr-Commit-Position: refs/heads/master@{#31061}

Patch Set 1 #

Patch Set 2 : meh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M test/benchmarks/benchmarks.status View 1 chunk +6 lines, -1 line 0 comments Download
M test/cctest/cctest.status View 2 chunks +5 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 3 chunks +18 lines, -1 line 0 comments Download
M test/simdjs/simdjs.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/testrunner/local/execution.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385443002/1
5 years, 2 months ago (2015-10-01 14:57:11 UTC) #2
Michael Achenbach
PTAL
5 years, 2 months ago (2015-10-01 14:59:35 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/10282)
5 years, 2 months ago (2015-10-01 15:00:04 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385443002/20001
5 years, 2 months ago (2015-10-01 15:02:38 UTC) #8
tandrii(chromium)
lgtm in spirit, but I have no idea about .status files.
5 years, 2 months ago (2015-10-01 15:11:28 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-01 16:08:19 UTC) #11
Jakob Kummerow
Hm... the perf data collection mechanism would solve this problem without the need for manual ...
5 years, 2 months ago (2015-10-01 16:16:27 UTC) #12
tandrii(chromium)
On 2015/10/01 16:16:27, Jakob wrote: > Hm... the perf data collection mechanism would solve this ...
5 years, 2 months ago (2015-10-01 16:56:30 UTC) #13
Michael Achenbach
On 2015/10/01 16:56:30, tandrii(chromium) wrote: > On 2015/10/01 16:16:27, Jakob wrote: > > Hm... the ...
5 years, 2 months ago (2015-10-01 19:16:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385443002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385443002/20001
5 years, 2 months ago (2015-10-01 19:17:05 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-01 19:19:12 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 19:19:24 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/366dc81143d2b2d4f58a4974ae528f081b05690b
Cr-Commit-Position: refs/heads/master@{#31061}

Powered by Google App Engine
This is Rietveld 408576698