Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 138543008: Vertical scrollbar width becomes zero in case of overlay scrollbar. (Closed)

Created:
6 years, 10 months ago by pals
Modified:
6 years, 10 months ago
Reviewers:
eseidel
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Vertical scrollbar width becomes zero in case of overlay scrollbar. Chrome on Mac OS is having overlay scrollbars. So, we need to take care of the verticalScrollbarWidth() if we have overlay scrollbars. BUG=335285 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166316

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebased #

Patch Set 4 : Added NeedsRebaseline for Mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -7 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/fast/forms/select-multiple-rtl.html View 1 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/platform/linux/fast/forms/select-multiple-rtl-expected.png View 1 Binary file 0 comments Download
A LayoutTests/platform/linux/fast/forms/select-multiple-rtl-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderListBox.cpp View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 35 (0 generated)
pals
Please review.
6 years, 10 months ago (2014-01-30 13:53:19 UTC) #1
eseidel
Can we test this? Even if the test only fails on mac?
6 years, 10 months ago (2014-01-30 19:04:45 UTC) #2
pals
On 2014/01/30 19:04:45, eseidel wrote: > Can we test this? Even if the test only ...
6 years, 10 months ago (2014-01-31 12:33:24 UTC) #3
eseidel
lgtm
6 years, 10 months ago (2014-01-31 19:46:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/138543008/50001
6 years, 10 months ago (2014-01-31 19:47:10 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-01-31 19:47:14 UTC) #6
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-01-31 19:47:15 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-01-31 19:47:25 UTC) #8
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 10 months ago (2014-02-01 14:08:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/138543008/160001
6 years, 10 months ago (2014-02-01 14:08:23 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-01 15:12:00 UTC) #11
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=17047
6 years, 10 months ago (2014-02-01 15:12:01 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 15:12:07 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 15:12:08 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 15:12:09 UTC) #15
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 10 months ago (2014-02-01 19:06:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/138543008/160001
6 years, 10 months ago (2014-02-01 19:06:55 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-01 20:59:38 UTC) #18
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=10460
6 years, 10 months ago (2014-02-01 20:59:39 UTC) #19
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 20:59:39 UTC) #20
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 20:59:40 UTC) #21
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-01 20:59:48 UTC) #22
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 10 months ago (2014-02-03 09:18:05 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/138543008/160001
6 years, 10 months ago (2014-02-03 09:18:20 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-03 12:08:15 UTC) #25
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=17118
6 years, 10 months ago (2014-02-03 12:08:16 UTC) #26
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 12:08:21 UTC) #27
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 12:08:21 UTC) #28
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 12:08:25 UTC) #29
pals
The CQ bit was checked by sanjoy.pal@samsung.com
6 years, 10 months ago (2014-02-03 13:33:04 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/138543008/540001
6 years, 10 months ago (2014-02-03 13:33:18 UTC) #31
commit-bot: I haz the power
Change committed as 166316
6 years, 10 months ago (2014-02-03 16:22:17 UTC) #32
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 16:22:19 UTC) #33
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 16:22:23 UTC) #34
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 16:22:26 UTC) #35
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698