Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 1385423002: dart2js cps_ir: Use interceptors for is-checks (version 2) (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: fix analyzer warnings Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
index a969bdbece7a3e910938cf7400c4c73f8d7cd0dd..2b3c95d7cb8205b95bc3d58e82b31de306c4ae24 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
@@ -346,7 +346,15 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitTypeTest(cps_ir.TypeTest node) {
String value = formatReference(node.value);
String args = node.typeArguments.map(formatReference).join(', ');
- return "TypeTest ($value ${node.dartType} ($args))";
+ String interceptor = node.interceptor == null
+ ? ''
+ : ' ${formatReference(node.interceptor)}';
+ return "TypeTest ($value ${node.dartType} ($args)$interceptor)";
+ }
+
+ visitTypeTestViaFlag(cps_ir.TypeTestViaFlag node) {
+ String interceptor = formatReference(node.interceptor);
+ return "TypeTestViaFlag ($interceptor ${node.dartType})";
}
visitApplyBuiltinOperator(cps_ir.ApplyBuiltinOperator node) {
@@ -643,6 +651,10 @@ class BlockCollector implements cps_ir.Visitor {
unexpectedNode(node);
}
+ visitTypeTestViaFlag(cps_ir.TypeTestViaFlag node) {
+ unexpectedNode(node);
+ }
+
visitApplyBuiltinOperator(cps_ir.ApplyBuiltinOperator node) {
unexpectedNode(node);
}
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart ('k') | pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698