dart2js cps_ir: Use interceptors for is-checks (version 2)

pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
index a969bdbece7a3e910938cf7400c4c73f8d7cd0dd..e5ec2a6cc340e361492ab80cd44478cf7c18959d 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
@@ -346,7 +346,15 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
   visitTypeTest(cps_ir.TypeTest node) {
     String value = formatReference(node.value);
     String args = node.typeArguments.map(formatReference).join(', ');
-    return "TypeTest ($value ${node.dartType} ($args))";
+    String interceptor = node.interceptor == null
+        ? ''
+        : ' ${formatReference(node.interceptor)}';
+    return "TypeTest ($value ${node.dartType} ($args)$interceptor)";

[sra1, 2015/10/07 04:01:28]

How is this tested?

[Kevin Millikin (Google), 2015/10/07 14:10:49]

Manually.  Set the string constant DUMP_IR in the environment, it's a pattern
that's used to construct a regexp that matches functions that will be dumped. 
So if you just set the environment variable DART_VM_OPTIONS="-DDUMP_IR=" and run
the dart2js script then that will match everything because it's an empty pattern
string.

Dart2js will write out a file named dart.cfg (this filename is hardcoded) in the
working directory.

Go to http://mrale.ph/irhydra/2/ and click on the file folder in the upper
left-hand corner.  Open the dart.cfg file and inspect it.

+  }
+
+  visitTypeTestViaFlag(cps_ir.TypeTestViaFlag node) {
+    String interceptor = formatReference(node.interceptor);
+    return "TypeTestRaw ($interceptor ${node.dartType})";

[sra1, 2015/10/07 04:01:28]

TypeTestRaw -> TypeTestViaFlag

[sra1, 2015/10/07 17:45:58]

Done.

   }
 
   visitApplyBuiltinOperator(cps_ir.ApplyBuiltinOperator node) {
@@ -643,6 +651,10 @@ class BlockCollector implements cps_ir.Visitor {
     unexpectedNode(node);
   }
 
+  visitTypeTestViaFlag(cps_ir.TypeTestViaFlag node) {
+    unexpectedNode(node);
+  }
+
   visitApplyBuiltinOperator(cps_ir.ApplyBuiltinOperator node) {
     unexpectedNode(node);
   }