CFI: download LLVM Gold plugin, if requested by env var or GYP_DEFINES.

CFI: download LLVM Gold plugin, if requested by env var or GYP_DEFINES.

BUG=chromium:536159
Committed: https://crrev.com/31561fb7940376f326f5881a96f4dc0c39f9d594
Cr-Commit-Position: refs/heads/master@{#353437}

[krasin, 2015-10-09 21:34:09]

krasin@google.com changed reviewers:
+ hans@chromium.org, thakis@chromium.org

[Nico, 2015-10-09 21:40:10]

https://codereview.chromium.org/1385403006/diff/1/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/1385403006/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.sh:58: [[ "$GYP_DEFINES" =~ .*branding=Chrome.* ]] ;
then
Let's do the same as
https://code.google.com/p/chromium/codesearch#chromium/src/build/linux/sysroo...
and only do this if the latter 2 are both true; drop the first

https://codereview.chromium.org/1385403006/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.sh:245: [[ -f "${LLVM_BUILD_DIR}/lib/LLVMgold.so" ]];
then
with this setup it can theoretically happen that an old LLVMgold plugin happens
to be around. if that turns out to be a problem, I suppose we could have another
stamp file for the plugin, but I think this is fine as-is for nmow.

[hans, 2015-10-09 21:42:48]

https://codereview.chromium.org/1385403006/diff/1/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/1385403006/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.sh:56: if [[ "$GYP_DEFINES" =~ .*cfi_vptr=1.* ]] || \
Doesn't this still need to be guarded by "if Linux ..."?

[krasin, 2015-10-09 21:50:18]

https://codereview.chromium.org/1385403006/diff/1/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/1385403006/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.sh:56: if [[ "$GYP_DEFINES" =~ .*cfi_vptr=1.* ]] || \
On 2015/10/09 21:42:48, hans wrote:
> Doesn't this still need to be guarded by "if Linux ..."?

Done.

https://codereview.chromium.org/1385403006/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.sh:58: [[ "$GYP_DEFINES" =~ .*branding=Chrome.* ]] ;
then
On 2015/10/09 21:40:10, Nico (offline until Fri Oct 9) wrote:
> Let's do the same as
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/linux/sysroo...
> and only do this if the latter 2 are both true; drop the first

Done.

https://codereview.chromium.org/1385403006/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.sh:245: [[ -f "${LLVM_BUILD_DIR}/lib/LLVMgold.so" ]];
then
On 2015/10/09 21:40:10, Nico (offline until Fri Oct 9) wrote:
> with this setup it can theoretically happen that an old LLVMgold plugin
happens
> to be around. if that turns out to be a problem, I suppose we could have
another
> stamp file for the plugin, but I think this is fine as-is for nmow.

I raised this point, Hans correctly pointed out that we delete the whole
directory, if a new version of Clang is downloaded (including the plugin):
https://codereview.chromium.org/1373043003/#msg13

[Nico, 2015-10-09 21:52:38]

lgtm, thanks!

https://codereview.chromium.org/1385403006/diff/1/tools/clang/scripts/update.sh
File tools/clang/scripts/update.sh (right):

https://codereview.chromium.org/1385403006/diff/1/tools/clang/scripts/update....
tools/clang/scripts/update.sh:245: [[ -f "${LLVM_BUILD_DIR}/lib/LLVMgold.so" ]];
then
On 2015/10/09 21:50:18, krasin wrote:
> On 2015/10/09 21:40:10, Nico (offline until Fri Oct 9) wrote:
> > with this setup it can theoretically happen that an old LLVMgold plugin
> happens
> > to be around. if that turns out to be a problem, I suppose we could have
> another
> > stamp file for the plugin, but I think this is fine as-is for nmow.
> 
> I raised this point, Hans correctly pointed out that we delete the whole
> directory, if a new version of Clang is downloaded (including the plugin):
> https://codereview.chromium.org/1373043003/#msg13

Smart guy, that Hans!

[krasin, 2015-10-09 22:20:44]

The CQ bit was checked by krasin@google.com

[commit-bot: I haz the power, 2015-10-09 22:21:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1385403006/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1385403006/20001

[commit-bot: I haz the power, 2015-10-10 00:40:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-10 00:43:41]

Patchset 2 (id:??) landed as
https://crrev.com/31561fb7940376f326f5881a96f4dc0c39f9d594
Cr-Commit-Position: refs/heads/master@{#353437}