Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 13854008: Unguard VIEWPORT (always enabled) (Closed)

Created:
7 years, 8 months ago by pilgrim_google
Modified:
7 years, 7 months ago
CC:
blink-reviews, darin (slow to review)
Visibility:
Public.

Description

Unguard VIEWPORT (always enabled) BUG=None R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149358

Patch Set 1 #

Patch Set 2 : Repatch to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M Source/WebKit/chromium/src/ChromeClientImpl.cpp View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/ViewportAnchor.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/WebKit/chromium/src/ViewportAnchor.cpp View 1 2 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/src/WebViewImpl.cpp View 1 4 chunks +0 lines, -4 lines 0 comments Download
M Source/WebKit/chromium/tests/WebFrameTest.cpp View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/features.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
pilgrim_google
7 years, 8 months ago (2013-04-26 15:03:20 UTC) #1
eseidel
lgtm OK.
7 years, 8 months ago (2013-04-26 18:26:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/13854008/1
7 years, 8 months ago (2013-04-26 19:39:38 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=5779
7 years, 8 months ago (2013-04-26 20:24:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/13854008/1
7 years, 8 months ago (2013-04-26 20:49:43 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=5801
7 years, 8 months ago (2013-04-26 21:26:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/13854008/1
7 years, 8 months ago (2013-04-26 23:54:13 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Source/WebKit/chromium/tests/WebFrameTest.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 8 months ago (2013-04-26 23:54:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/13854008/13001
7 years, 7 months ago (2013-04-29 18:36:34 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6117
7 years, 7 months ago (2013-04-29 19:13:30 UTC) #10
pilgrim_google
7 years, 7 months ago (2013-04-29 20:07:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 manually as r149358 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698