Issue 1385363002: convert TypedData to ArrayBufferView, not ArrayBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1385363002: convert TypedData to ArrayBufferView, not ArrayBuffer (Closed)

Created:
5 years, 2 months ago by Alan Knight

Modified:
5 years, 2 months ago

Reviewers:
vsm, terry, siva

CC:
reviews+dom_dartlang.org

Base URL:
svn://svn.chromium.org/blink/branches/dart/dartium

Target Ref:
refs/remotes/git-svn

Visibility:
Public.

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/bindings/core/dart/V8Converter.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Alan Knight

This doesn't solve the identity issue, but at least calls to Crypto.getRandomValues don't fail because ...

5 years, 2 months ago (2015-10-06 23:46:46 UTC) #2

vsm

lgtm Your change better matches my understanding than the old code. Roughly: Dart TypedDart == ...

5 years, 2 months ago (2015-10-06 23:53:02 UTC) #3

Alan Knight

5 years, 2 months ago (2015-10-07 15:54:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 202674 (tree was closed).