Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1385333002: [Chromecast] Cleanup the API for creating MediaPipelineBackend. (Closed)

Created:
5 years, 2 months ago by alokp
Modified:
5 years, 2 months ago
Reviewers:
lcwu1
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Cleanup the API for creating MediaPipelineBackend. The patch also moves the construction of AudioManagerFactory to PreCreateThreads stage, which happens just before AudioManager is created. Committed: https://crrev.com/a15b1645432b1ee5d9c9ade87da3a76b51b01a67 Cr-Commit-Position: refs/heads/master@{#352766}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -45 lines) Patch
M chromecast/browser/cast_browser_main_parts.h View 3 chunks +2 lines, -10 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M chromecast/browser/cast_content_browser_client.cc View 3 chunks +4 lines, -11 lines 0 comments Download
M chromecast/media/audio/cast_audio_manager.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chromecast/media/audio/cast_audio_manager.cc View 2 chunks +3 lines, -10 lines 0 comments Download
M chromecast/media/audio/cast_audio_output_stream.cc View 5 chunks +9 lines, -1 line 0 comments Download
M chromecast/media/audio/cast_audio_output_stream_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
alokp
5 years, 2 months ago (2015-10-06 23:32:57 UTC) #2
lcwu1
lgtm
5 years, 2 months ago (2015-10-07 01:01:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385333002/1
5 years, 2 months ago (2015-10-07 03:46:51 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 04:09:49 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 04:11:09 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a15b1645432b1ee5d9c9ade87da3a76b51b01a67
Cr-Commit-Position: refs/heads/master@{#352766}

Powered by Google App Engine
This is Rietveld 408576698