third_party/WebKit/Source/core/page/FrameTree.cpp - Issue 1385323004: [Oilpan] Fix wrong usage of Vector<Frame*> in FrameTree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FrameTree.cpp

Issue 1385323004: [Oilpan] Fix wrong usage of Vector<Frame*> in FrameTree (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/page/FrameTree.cpp

diff --git a/third_party/WebKit/Source/core/page/FrameTree.cpp b/third_party/WebKit/Source/core/page/FrameTree.cpp

index 2554746351ea8f385d226a82dcb661a06a7b595c..9529551f1b5c8e27a67c3dfc4707361b6236c565 100644

--- a/third_party/WebKit/Source/core/page/FrameTree.cpp

+++ b/third_party/WebKit/Source/core/page/FrameTree.cpp

@@ -144,7 +144,7 @@ AtomicString FrameTree::uniqueChildName(const AtomicString& requestedName) const

const int framePathSuffixLength = 3;

// Find the nearest parent that has a frame with a path in it.

- Vector<Frame*, 16> chain;

+ WillBeHeapVector<RawPtrWillBeMember<Frame>, 16> chain;

Frame* frame;

for (frame = m_thisFrame; frame; frame = frame->tree().parent()) {

if (frame->tree().uniqueName().startsWith(framePathPrefix))

« no previous file with comments | « no previous file | no next file » | no next file with comments »