Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13853010: Make panels turn on or off shadow effect. (Closed)

Created:
7 years, 8 months ago by jianli
Modified:
7 years, 8 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, jennb, tfarina, sail+watch_chromium.org, dcheng
Visibility:
Public.

Description

Make panels turn on or off shadow effect. This is needed for stacking panels. The foreground panel windows will turn off the shadow while the background stack window will provider the shadow. BUG=223155, 177770 TEST=none due to no functionality change yet Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194615

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix per feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -0 lines) Patch
M chrome/browser/ui/cocoa/panels/panel_cocoa.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_cocoa.mm View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/panels/panel_gtk.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/panels/panel_gtk.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/detached_panel_collection.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/panels/docked_panel_collection.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/panels/native_panel.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/panel.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/panels/stacked_panel_collection.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/panels/panel_view.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/panels/panel_view.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jianli
7 years, 8 months ago (2013-04-16 22:47:37 UTC) #1
Dmitry Titov
https://codereview.chromium.org/13853010/diff/1/chrome/browser/ui/cocoa/panels/panel_cocoa.h File chrome/browser/ui/cocoa/panels/panel_cocoa.h (right): https://codereview.chromium.org/13853010/diff/1/chrome/browser/ui/cocoa/panels/panel_cocoa.h#newcode67 chrome/browser/ui/cocoa/panels/panel_cocoa.h:67: virtual void SetPanelHasShadow(bool has_shadow) OVERRIDE; Naming: I think "ShowShadow(bool ...
7 years, 8 months ago (2013-04-16 23:26:47 UTC) #2
jianli
https://codereview.chromium.org/13853010/diff/1/chrome/browser/ui/cocoa/panels/panel_cocoa.h File chrome/browser/ui/cocoa/panels/panel_cocoa.h (right): https://codereview.chromium.org/13853010/diff/1/chrome/browser/ui/cocoa/panels/panel_cocoa.h#newcode67 chrome/browser/ui/cocoa/panels/panel_cocoa.h:67: virtual void SetPanelHasShadow(bool has_shadow) OVERRIDE; On 2013/04/16 23:26:47, Dmitry ...
7 years, 8 months ago (2013-04-16 23:46:03 UTC) #3
Dmitry Titov
lgtm
7 years, 8 months ago (2013-04-16 23:52:32 UTC) #4
jianli
7 years, 8 months ago (2013-04-17 17:09:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r194615 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698