Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4123)

Unified Diff: chrome/browser/resources/feedback.js

Issue 13853008: Set the attach file checkbox to checked when launched from an extension. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/feedback.js
diff --git a/chrome/browser/resources/feedback.js b/chrome/browser/resources/feedback.js
index 14ae6fb950a2fda2eb8746aa7bf79f169de75f93..edb51ffa7692bb2c408ac5c3419839d0de557d0c 100644
--- a/chrome/browser/resources/feedback.js
+++ b/chrome/browser/resources/feedback.js
@@ -305,11 +305,15 @@ function load() {
'filePath': '',
};
- var query = window.location.search.substr(1).split('&');
Dan Beam 2013/04/16 23:34:05 var loc = window.location; var query = loc.search.
rkc 2013/04/17 00:38:07 Modified this a bit to make it slightly more under
- for (var i = 0; i < query.length; i++) {
- // Decode and store each parameter value.
- parameter = query[i].split('=');
- parameters[parameter[0]] = decodeURIComponent(parameter[1]);
+ var queryPos = window.location.href.indexOf('?');
+ if (queryPos !== -1) {
Dan Beam 2013/04/16 22:01:12 what is the point of this diff?
rkc 2013/04/16 22:07:34 I had changed this to use window.location.search (
Dan Beam 2013/04/16 23:20:18 can you give me a full URL of an example that does
rkc 2013/04/16 23:22:58 chrome://feedback/#0?description=&categoryTag=From
+ var query = window.location.href.substring(queryPos + 1).split('&');
+ for (var i = 0; i < query.length; i++) {
+ // Get an array of parameters in 'name=value' form.
+ // Decode and store each parameter value.
+ parameter = query[i].split('=');
+ parameters[parameter[0]] = decodeURIComponent(parameter[1]);
+ }
}
// Set the initial description text.
« chrome/browser/resources/feedback.html ('K') | « chrome/browser/resources/feedback.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698