Set the attach file checkbox to checked when launched from an extension.

chrome/browser/resources/feedback.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Constants.
 /** @const */ var FEEDBACK_LANDING_PAGE =
     'https://www.google.com/support/chrome/go/feedback_confirmation';
 /** @const */ var MAX_ATTACH_FILE_SIZE = 3 * 1024 * 1024;
 
 var selectedThumbnailDivId = '';
@@ skipping 287 matching lines @@
 
   // Set default values for the possible parameters, and then parse the actual
   // values from the URL href.
   var parameters = {
     'description': '',
     'categoryTag': '',
     'customPageUrl': '',
     'filePath': '',
   };
 
-  var query = window.location.search.substr(1).split('&');

[Dan Beam, 2013/04/16 23:34:05]

var loc = window.location;
var query = loc.search.substr(1).split('&');
if (loc.hash.indexOf('?') >= 0)
  query = query.concat(loc.hash.split('?').slice(1).join('').split('&'));

[rkc, 2013/04/17 00:38:07]

Modified this a bit to make it slightly more understandable (at least to me) and
added comments.
Done.

-  for (var i = 0; i < query.length; i++) {
-    // Decode and store each parameter value.
-    parameter = query[i].split('=');
-    parameters[parameter[0]] = decodeURIComponent(parameter[1]);
+  var queryPos = window.location.href.indexOf('?');
+  if (queryPos !== -1) {

[Dan Beam, 2013/04/16 22:01:12]

what is the point of this diff?

[rkc, 2013/04/16 22:07:34]

I had changed this to use window.location.search (as per your review comment on
a previous CL) but that broke the case in which the code invoking it provides a
#0 on the href (as older extensions do). This code searches for the first ? to
seperate out the query string from everything else - I can change this to
something else if it works better?

[Dan Beam, 2013/04/16 23:20:18]

can you give me a full URL of an example that doesn't work?

[rkc, 2013/04/16 23:22:58]

chrome://feedback/#0?description=&categoryTag=FromQuickoffice&customPageUrl=chrome-extension://gbkeegbaiigmenfmjfclcdgdpimamgkj/views/qowt.html&filePath=/Downloads/resume.doc

+    var query = window.location.href.substring(queryPos + 1).split('&');
+    for (var i = 0; i < query.length; i++) {
+      // Get an array of parameters in 'name=value' form.
+      // Decode and store each parameter value.
+      parameter = query[i].split('=');
+      parameters[parameter[0]] = decodeURIComponent(parameter[1]);
+    }
   }
 
   // Set the initial description text.
   $('description-text').textContent = parameters['description'];
   // If a page url is spcified in the parameters, override the default page url.
   if (parameters['customPageUrl'] != '') {
     $('page-url-text').value = parameters['customPageUrl'];
     // and disable the page image, since it doesn't make sense on a custom url.
     $('screenshot-checkbox').checked = false;
     forceDisableScreenshots = true;
@@ skipping 73 matching lines @@
 
   if (!defaults.disableScreenshots)
     enableScreenshots();
 
   if (defaults.useSaved) {
     $('screenshot-link-tosaved').hidden = false;
   }
 }
 
 window.addEventListener('DOMContentLoaded', load);