Lint support for the new task model.

Lint support for the new task model.

Related bug: https://github.com/dart-lang/analyzer_cli/issues/64

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/fe76c6f3c4684122c70288d936e90def2eff6040

[pquitslund, 2015-10-06 22:18:12]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[pquitslund, 2015-10-06 22:18:12]

Quick question about setting up inputs:

https://codereview.chromium.org/1385293002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1385293002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2525: TYPE_PROVIDER_INPUT:
TYPE_PROVIDER.of(AnalysisContextTarget.request)
OK: I'm sure this can be pruned...  Advise?

[Brian Wilkerson, 2015-10-06 22:40:54]

Aside from the clean-up you asked about, the only other thing I'd recommend is
adding some tests for the new task. You can probably crib off of the class
GenerateHintsTaskTest (or something like that). Then LGTM.

https://codereview.chromium.org/1385293002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1385293002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2525: TYPE_PROVIDER_INPUT:
TYPE_PROVIDER.of(AnalysisContextTarget.request)
Yes. The only input you use is RESOLVED_UNIT_INPUT. The rest can be removed, as
can the constants defined for them.

[pquitslund, 2015-10-06 23:41:38]

On 2015/10/06 22:40:54, Brian Wilkerson wrote:
> Aside from the clean-up you asked about, the only other thing I'd recommend is
> adding some tests for the new task. You can probably crib off of the class
> GenerateHintsTaskTest (or something like that). Then LGTM.

Done!

> 
>
https://codereview.chromium.org/1385293002/diff/1/pkg/analyzer/lib/src/task/d...
> File pkg/analyzer/lib/src/task/dart.dart (right):
> 
>
https://codereview.chromium.org/1385293002/diff/1/pkg/analyzer/lib/src/task/d...
> pkg/analyzer/lib/src/task/dart.dart:2525: TYPE_PROVIDER_INPUT:
> TYPE_PROVIDER.of(AnalysisContextTarget.request)
> Yes. The only input you use is RESOLVED_UNIT_INPUT. The rest can be removed,
as
> can the constants defined for them.

Perfect.

[pquitslund, 2015-10-06 23:45:50]

Committed patchset #2 (id:20001) manually as
fe76c6f3c4684122c70288d936e90def2eff6040 (presubmit successful).

[scheglov, 2015-10-09 03:45:10]

scheglov@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-10-09 03:45:10]

https://codereview.chromium.org/1385293002/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1385293002/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/dart.dart:2446: static const String
USED_LOCAL_ELEMENTS_INPUT = 'USED_LOCAL_ELEMENTS';
It seems that this and the next two input names are not used :-)

https://codereview.chromium.org/1385293002/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/dart.dart:3006: LINTS_INPUT: LINTS.of(unit),
Would be nice to keep these sorted.

[pquitslund, 2015-10-09 15:25:36]

Thanks!

https://codereview.chromium.org/1385293002/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/1385293002/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/dart.dart:2446: static const String
USED_LOCAL_ELEMENTS_INPUT = 'USED_LOCAL_ELEMENTS';
On 2015/10/09 03:45:10, scheglov wrote:
> It seems that this and the next two input names are not used :-)

Good catch!

https://codereview.chromium.org/1386323003/

https://codereview.chromium.org/1385293002/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/dart.dart:3006: LINTS_INPUT: LINTS.of(unit),
On 2015/10/09 03:45:10, scheglov wrote:
> Would be nice to keep these sorted.

I think this has been fixed already.