Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1385233002: Move scissor state to GrAppliedClip (Closed)

Created:
5 years, 2 months ago by bsalomon
Modified:
5 years, 1 month ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@enum
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : revert accidental whitespace change #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M src/gpu/GrClipMaskManager.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 3 4 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 6 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
bsalomon
5 years, 2 months ago (2015-10-06 19:50:36 UTC) #2
robertphillips
lgtm https://codereview.chromium.org/1385233002/diff/20001/src/gpu/GrClipMaskManager.h File src/gpu/GrClipMaskManager.h (right): https://codereview.chromium.org/1385233002/diff/20001/src/gpu/GrClipMaskManager.h#newcode32 src/gpu/GrClipMaskManager.h:32: void setScissorState(const GrScissorState& newState); ?
5 years, 2 months ago (2015-10-07 12:28:04 UTC) #3
bsalomon
https://codereview.chromium.org/1385233002/diff/20001/src/gpu/GrClipMaskManager.h File src/gpu/GrClipMaskManager.h (right): https://codereview.chromium.org/1385233002/diff/20001/src/gpu/GrClipMaskManager.h#newcode32 src/gpu/GrClipMaskManager.h:32: On 2015/10/07 12:28:04, robertphillips wrote: > void setScissorState(const GrScissorState& ...
5 years, 2 months ago (2015-10-07 13:31:24 UTC) #4
bsalomon
5 years, 2 months ago (2015-10-07 13:31:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385233002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385233002/40001
5 years, 2 months ago (2015-10-07 17:01:32 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3516) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 2 months ago (2015-10-07 17:02:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385233002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385233002/60001
5 years, 1 month ago (2015-10-27 13:31:24 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 13:42:54 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/e91f7b5ceca22e2e68e252b55d59804d1ce8ae4d

Powered by Google App Engine
This is Rietveld 408576698