public/web/WebWidgetClient.h - Issue 138523003: Removed unnecessary parameter from didActivateCompositor()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebWidgetClient.h

Issue 138523003: Removed unnecessary parameter from didActivateCompositor() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removing unnecessary argument in another file: Source/web/WebPagePopupImpl.cpp Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebWidgetClient.h

diff --git a/public/web/WebWidgetClient.h b/public/web/WebWidgetClient.h

index c8c18a137d6739f9ef148011d8a1bbd6ff471029..a5c8b454ac2611dc007d0fd35a9913fe76fa5839 100644

--- a/public/web/WebWidgetClient.h

+++ b/public/web/WebWidgetClient.h

@@ -62,7 +62,8 @@ public:

// The parameter to didActivateCompositor() is meaningless.

// FIXME: The older definiton of didActivateCompositor (i.e with arguments)

// and all its corresponding call is to removed once the dependent chromium

- // side patch https://codereview.chromium.org/137893025/ lands.

+ // side patch https://codereview.chromium.org/137893025/ lands and all overrides

+ // of older definition are removed from chromium side.

virtual void didActivateCompositor() { }

virtual void didActivateCompositor(int deprecated) { }

virtual void didDeactivateCompositor() { }

« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »