Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Side by Side Diff: public/web/WebWidgetClient.h

Issue 138523003: Removed unnecessary parameter from didActivateCompositor() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removing unnecessary argument in another file: Source/web/WebPagePopupImpl.cpp Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 // scrolled by the specified dx and dy amounts. 55 // scrolled by the specified dx and dy amounts.
56 virtual void didScrollRect(int dx, int dy, const WebRect& clipRect) { } 56 virtual void didScrollRect(int dx, int dy, const WebRect& clipRect) { }
57 57
58 // Called when the Widget has changed size as a result of an auto-resize. 58 // Called when the Widget has changed size as a result of an auto-resize.
59 virtual void didAutoResize(const WebSize& newSize) { } 59 virtual void didAutoResize(const WebSize& newSize) { }
60 60
61 // Called when the compositor is enabled or disabled. 61 // Called when the compositor is enabled or disabled.
62 // The parameter to didActivateCompositor() is meaningless. 62 // The parameter to didActivateCompositor() is meaningless.
63 // FIXME: The older definiton of didActivateCompositor (i.e with arguments) 63 // FIXME: The older definiton of didActivateCompositor (i.e with arguments)
64 // and all its corresponding call is to removed once the dependent chromium 64 // and all its corresponding call is to removed once the dependent chromium
65 // side patch https://codereview.chromium.org/137893025/ lands. 65 // side patch https://codereview.chromium.org/137893025/ lands and all overr ides
66 // of older definition are removed from chromium side.
66 virtual void didActivateCompositor() { } 67 virtual void didActivateCompositor() { }
67 virtual void didActivateCompositor(int deprecated) { } 68 virtual void didActivateCompositor(int deprecated) { }
68 virtual void didDeactivateCompositor() { } 69 virtual void didDeactivateCompositor() { }
69 70
70 // Attempt to initialize compositing for this widget. If this is successful, 71 // Attempt to initialize compositing for this widget. If this is successful,
71 // layerTreeView() will return a valid WebLayerTreeView. 72 // layerTreeView() will return a valid WebLayerTreeView.
72 virtual void initializeLayerTreeView() { } 73 virtual void initializeLayerTreeView() { }
73 74
74 // Return a compositing view used for this widget. This is owned by the 75 // Return a compositing view used for this widget. This is owned by the
75 // WebWidgetClient. 76 // WebWidgetClient.
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 // of the touch actions that are permitted for this touch. 182 // of the touch actions that are permitted for this touch.
182 virtual void setTouchAction(WebTouchAction touchAction) { } 183 virtual void setTouchAction(WebTouchAction touchAction) { }
183 184
184 protected: 185 protected:
185 ~WebWidgetClient() { } 186 ~WebWidgetClient() { }
186 }; 187 };
187 188
188 } // namespace blink 189 } // namespace blink
189 190
190 #endif 191 #endif
OLDNEW
« no previous file with comments | « Source/web/WebViewImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698