Issue 13852042: Revert 195143 "Prevent chrome.app JSON schema from loading on ev..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13852042: Revert 195143 "Prevent chrome.app JSON schema from loading on ev..." (Closed)

Created:
7 years, 8 months ago by Marijn Kruisselbrink

Modified:
7 years, 8 months ago

Reviewers:
cduvall

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 195143 "Prevent chrome.app JSON schema from loading on ev..." This caused WebstoreStartupInstallerTest.ArgumentValidation to start crashing with some odd v8 backtrace. BUG=233592 > Prevent chrome.app JSON schema from loading on every page > > The app API along with app.window and app.runtime have been converted to use > the feature system. Bindings are not added to the chrome object for unavailable > APIs that are children of available APIs. For example, if chrome.app is > available, we will not add lazy bindings to chrome for app.window and > app.runtime. This eliminates the need to load the app schema, because we no > longer need to get chrome.app to add the app.runtime and app.window bindings. > > BUG=55316 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194837 > > Review URL: https://chromiumcodereview.appspot.com/13604005 TBR=cduvall@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195230

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+53 lines, -106 lines)			Patch
M	trunk/src/chrome/common/extensions/api/_api_features.json	View	3 chunks	+2 lines, -24 lines	0 comments	Download
M	trunk/src/chrome/common/extensions/api/app.json	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/common/extensions/api/extension_api_unittest.cc	View	2 chunks	+7 lines, -12 lines	0 comments	Download
M	trunk/src/chrome/renderer/extensions/chrome_v8_context.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/renderer/extensions/chrome_v8_context.cc	View	1 chunk	+1 line, -12 lines	0 comments	Download
M	trunk/src/chrome/renderer/extensions/dispatcher.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	trunk/src/chrome/renderer/extensions/dispatcher.cc	View	4 chunks	+38 lines, -45 lines	0 comments	Download
M	trunk/src/chrome/test/data/extensions/api_test/stubs/content_script.js	View	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r195230.

Expand Messages | Collapse Messages