Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Unified Diff: tools/clang/rewrite_scoped_refptr/tests/logging-checks-expected.cc

Issue 1385193002: Bisect clang Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: 246985 Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_scoped_refptr/tests/logging-checks-expected.cc
diff --git a/tools/clang/rewrite_scoped_refptr/tests/logging-checks-expected.cc b/tools/clang/rewrite_scoped_refptr/tests/logging-checks-expected.cc
new file mode 100644
index 0000000000000000000000000000000000000000..000638fda6eeff179068622b1947e989dfbdfebb
--- /dev/null
+++ b/tools/clang/rewrite_scoped_refptr/tests/logging-checks-expected.cc
@@ -0,0 +1,28 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/logging.h"
+#include "base/memory/ref_counted.h"
+
+struct Foo : public base::RefCounted<Foo> {
+ int dummy;
+};
+
+// Rewriting the logging macros is a bit tricky. The CHECK_OP macros actually
+// wrap a function where the actual comparison happens. Make sure that the tool
+// is correctly matching the AST nodes generated by the macros and generating
+// the appropriate replacements.
+void TestFunction() {
+ scoped_refptr<Foo> a;
+ Foo* b;
+
+ CHECK_EQ(a.get(), b);
+ CHECK_EQ(b, a.get());
+
+ CHECK_NE(a.get(), b);
+ CHECK_NE(b, a.get());
+
+ CHECK(a.get());
+ CHECK(!a.get());
+}

Powered by Google App Engine
This is Rietveld 408576698