Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/clang/plugins/tests/virtual_specifiers.txt

Issue 1385193002: Bisect clang Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: 246985 Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/virtual_specifiers.cpp ('k') | tools/clang/plugins/tests/warn_only.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/virtual_specifiers.txt
diff --git a/tools/clang/plugins/tests/virtual_specifiers.txt b/tools/clang/plugins/tests/virtual_specifiers.txt
new file mode 100644
index 0000000000000000000000000000000000000000..7b36d2330d5920f17cbfbe65f882f65acd099b3a
--- /dev/null
+++ b/tools/clang/plugins/tests/virtual_specifiers.txt
@@ -0,0 +1,69 @@
+virtual_specifiers.cpp:39:22: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ ~MissingOverride() {}
+ ^
+ override
+virtual_specifiers.cpp:40:12: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ void F() {}
+ ^
+ override
+virtual_specifiers.cpp:46:3: warning: [chromium-style] 'virtual' is redundant; 'override' implies 'virtual'.
+ virtual ~VirtualAndOverride() OVERRIDE {}
+ ^~~~~~~~
+virtual_specifiers.cpp:47:3: warning: [chromium-style] 'virtual' is redundant; 'override' implies 'virtual'.
+ virtual void F() OVERRIDE {}
+ ^~~~~~~~
+virtual_specifiers.cpp:52:3: warning: [chromium-style] 'virtual' is redundant; 'final' implies 'virtual'.
+ virtual ~VirtualAndFinal() FINAL {}
+ ^~~~~~~~
+virtual_specifiers.cpp:53:3: warning: [chromium-style] 'virtual' is redundant; 'final' implies 'virtual'.
+ virtual void F() FINAL {}
+ ^~~~~~~~
+virtual_specifiers.cpp:58:3: warning: [chromium-style] 'virtual' is redundant; 'override' implies 'virtual'.
+ virtual ~VirtualAndOverrideFinal() OVERRIDE FINAL {}
+ ^~~~~~~~
+virtual_specifiers.cpp:58:38: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.
+ virtual ~VirtualAndOverrideFinal() OVERRIDE FINAL {}
+ ^~~~~~~~~
+virtual_specifiers.cpp:13:18: note: expanded from macro 'OVERRIDE'
+#define OVERRIDE override
+ ^
+virtual_specifiers.cpp:59:3: warning: [chromium-style] 'virtual' is redundant; 'override' implies 'virtual'.
+ virtual void F() OVERRIDE FINAL {}
+ ^~~~~~~~
+virtual_specifiers.cpp:59:20: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.
+ virtual void F() OVERRIDE FINAL {}
+ ^~~~~~~~~
+virtual_specifiers.cpp:13:18: note: expanded from macro 'OVERRIDE'
+#define OVERRIDE override
+ ^
+virtual_specifiers.cpp:64:23: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.
+ ~OverrideAndFinal() OVERRIDE FINAL {}
+ ^~~~~~~~~
+virtual_specifiers.cpp:13:18: note: expanded from macro 'OVERRIDE'
+#define OVERRIDE override
+ ^
+virtual_specifiers.cpp:65:12: warning: [chromium-style] 'override' is redundant; 'final' implies 'override'.
+ void F() OVERRIDE FINAL {}
+ ^~~~~~~~~
+virtual_specifiers.cpp:13:18: note: expanded from macro 'OVERRIDE'
+#define OVERRIDE override
+ ^
+virtual_specifiers.cpp:70:20: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ virtual void F() = 0;
+ ^
+ override
+virtual_specifiers.cpp:74:12: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ void F() = 0;
+ ^
+ override
+virtual_specifiers.cpp:82:3: warning: [chromium-style] 'virtual' is redundant; 'override' implies 'virtual'.
+ virtual void F() override = 0;
+ ^~~~~~~~
+virtual_specifiers.cpp:111:20: warning: [chromium-style] Overriding method must be marked with 'override' or 'final'.
+ virtual ~MyTest();
+ ^
+ override
+virtual_specifiers.cpp:112:3: warning: [chromium-style] 'virtual' is redundant; 'override' implies 'virtual'.
+ virtual void SetUp() override;
+ ^~~~~~~~
+17 warnings generated.
« no previous file with comments | « tools/clang/plugins/tests/virtual_specifiers.cpp ('k') | tools/clang/plugins/tests/warn_only.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698