Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: tools/clang/plugins/tests/virtual_bodies.h

Issue 1385193002: Bisect clang Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: 246985 Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/plugins/tests/virtual_bodies.h
diff --git a/tools/clang/plugins/tests/virtual_bodies.h b/tools/clang/plugins/tests/virtual_bodies.h
new file mode 100644
index 0000000000000000000000000000000000000000..fb971c3f1e89dd0d8f7d8cced841dff0b7f4e288
--- /dev/null
+++ b/tools/clang/plugins/tests/virtual_bodies.h
@@ -0,0 +1,50 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef VIRTUAL_METHODS_H_
+#define VIRTUAL_METHODS_H_
+
+// Note: This is not actual windows.h but the stub file in system/windows.h
+#include <windows.h>
+
+#define CR_BEGIN_MSG_MAP_EX(theClass) virtual int f() { return 4; }
+#define BEGIN_SAFE_MSG_MAP_EX(theClass) virtual int g() { return 4; }
+
+// Should warn about virtual method usage.
+class VirtualMethodsInHeaders {
+ public:
+ // Don't complain about these.
+ virtual void MethodIsAbstract() = 0;
+ virtual void MethodHasNoArguments();
+ virtual void MethodHasEmptyDefaultImpl() {}
+
+ // But complain about this:
+ virtual bool ComplainAboutThis() { return true; }
+
+ SYSTEM_INLINE_VIRTUAL
+ CR_BEGIN_MSG_MAP_EX(Sub)
+ BEGIN_SAFE_MSG_MAP_EX(Sub)
+};
+
+// Complain on missing 'virtual' keyword in overrides.
+class WarnOnMissingVirtual : public VirtualMethodsInHeaders {
+ public:
+ void MethodHasNoArguments() override;
+};
+
+// Don't complain about things in a 'testing' namespace.
+namespace testing {
+struct TestStruct {};
+} // namespace testing
+
+class VirtualMethodsInHeadersTesting : public VirtualMethodsInHeaders {
+ public:
+ // Don't complain about no virtual testing methods.
+ void MethodHasNoArguments();
+
+ private:
+ testing::TestStruct tester_;
+};
+
+#endif // VIRTUAL_METHODS_H_
« no previous file with comments | « tools/clang/plugins/tests/virtual_base_method_also_final.txt ('k') | tools/clang/plugins/tests/virtual_bodies.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698