Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: tools/clang/plugins/tests/missing_ctor.h

Issue 1385193002: Bisect clang Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: 246985 Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/inline_ctor.txt ('k') | tools/clang/plugins/tests/missing_ctor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/missing_ctor.h
diff --git a/tools/clang/plugins/tests/missing_ctor.h b/tools/clang/plugins/tests/missing_ctor.h
new file mode 100644
index 0000000000000000000000000000000000000000..2587a10d9e75dd80b018d4ef771ca4ca4c82a92e
--- /dev/null
+++ b/tools/clang/plugins/tests/missing_ctor.h
@@ -0,0 +1,62 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MISSING_CTOR_H_
+#define MISSING_CTOR_H_
+
+struct MyString {
+ MyString();
+ ~MyString();
+ MyString(const MyString&);
+ MyString(MyString&&);
+};
+
+template <class T>
+struct MyVector {
+ MyVector();
+ ~MyVector();
+ MyVector(const MyVector&);
+ MyVector(MyVector&&);
+};
+
+// Note: this should warn for an implicit copy constructor too, but currently
+// doesn't, due to a plugin bug.
+class MissingCtorsArentOKInHeader {
+ public:
+
+ private:
+ MyVector<int> one_;
+ MyVector<MyString> two_;
+};
+
+// Inline move ctors shouldn't be warned about. Similar to the previous test
+// case, this also incorrectly fails to warn for the implicit copy ctor.
+class InlineImplicitMoveCtorOK {
+ public:
+ InlineImplicitMoveCtorOK();
+
+ private:
+ // ctor weight = 12, dtor weight = 9.
+ MyString one_;
+ MyString two_;
+ MyString three_;
+ int four_;
+ int five_;
+ int six_;
+};
+
+class ExplicitlyDefaultedInlineAlsoWarns {
+ public:
+ ExplicitlyDefaultedInlineAlsoWarns() = default;
+ ~ExplicitlyDefaultedInlineAlsoWarns() = default;
+ ExplicitlyDefaultedInlineAlsoWarns(
+ const ExplicitlyDefaultedInlineAlsoWarns&) = default;
+
+ private:
+ MyVector<int> one_;
+ MyVector<MyString> two_;
+
+};
+
+#endif // MISSING_CTOR_H_
« no previous file with comments | « tools/clang/plugins/tests/inline_ctor.txt ('k') | tools/clang/plugins/tests/missing_ctor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698