tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-original.cc - Issue 1385193002: Bisect clang

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/rewrite_scoped_refptr/tests/temp-bool-test-original.cc

Issue 1385193002: Bisect clang Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: 246985 Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "scoped_refptr.h"

	6

	7 struct Foo {

	8 int dummy;

	9 };

	10

	11 // A temporary scoped_refptr<T> is used in a boolean test. This doesn't result

	12 // in memory safety issues, but probably indicates a code smell. As such, the

	13 // tool intentionally skips this case so it can be manually handled.

	14 scoped_refptr<Foo> GetBuggyFoo() {

	15 return new Foo;

	16 }

	17 void UseBuggyFoo() {

	18 if (GetBuggyFoo())

	19 return;

	20 }

OLD	NEW